From: "Zengtao (B)" <prime.zeng@hisilicon.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: "cohuck@redhat.com" <cohuck@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterx@redhat.com" <peterx@redhat.com>
Subject: 答复: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device
Date: Mon, 12 Apr 2021 04:03:24 +0000 [thread overview]
Message-ID: <46881012f8214a8fa50d1ce2d10c5651@hisilicon.com> (raw)
In-Reply-To: <20210409173216.GA7405@nvidia.com>
> -----邮件原件-----
> 发件人: Jason Gunthorpe [mailto:jgg@nvidia.com]
> 发送时间: 2021年4月10日 1:32
> 收件人: Alex Williamson <alex.williamson@redhat.com>
> 抄送: Zengtao (B) <prime.zeng@hisilicon.com>; cohuck@redhat.com;
> kvm@vger.kernel.org; linux-kernel@vger.kernel.org; peterx@redhat.com
> 主题: Re: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device
>
> On Fri, Apr 09, 2021 at 08:24:00AM -0600, Alex Williamson wrote:
>
> > > > #define DRIVER_VERSION "0.3"
> > > > #define DRIVER_AUTHOR "Alex Williamson
> <alex.williamson@redhat.com>"
> > > > #define DRIVER_DESC "VFIO - User Level meta-driver"
> > > >
> > > > +#define VFIO_MAGIC 0x5646494f /* "VFIO" */
> > > Move to include/uapi/linux/magic.h ?
> >
> > Hmm, yeah, I suppose it probably should go there. Thanks.
>
> From my review we haven't been doing that unless it is actually uapi relavent
> for some reason (this is not)
>
Yes, it's not uapi relavent, and I still think it's better to put magic
in a single header, and currently not all micros in magic.h are for
uapi, some work should be done for that, but no ideas now, :)
> In particular with CH having a patch series to eliminate all of these cases and
> drop the constants..
>
Interested, could you share the links for that?
Thanks
Zengtao
> Jason
next prev parent reply other threads:[~2021-04-12 4:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 21:47 [PATCH v1 00/14] vfio: Device memory DMA mapping improvements Alex Williamson
2021-03-08 21:47 ` [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device Alex Williamson
2021-03-09 8:36 ` Christoph Hellwig
2021-04-09 4:54 ` 答复: " Zengtao (B)
2021-04-09 14:24 ` Alex Williamson
2021-04-09 17:32 ` Jason Gunthorpe
2021-04-12 4:03 ` Zengtao (B) [this message]
2021-04-12 4:09 ` 答复: " Zengtao (B)
2021-03-08 21:47 ` [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API Alex Williamson
2021-03-10 7:48 ` Christoph Hellwig
2021-03-10 12:19 ` Jason Gunthorpe
2021-03-10 15:28 ` Alex Williamson
2021-03-11 11:23 ` Christoph Hellwig
2021-03-08 21:47 ` [PATCH v1 03/14] vfio: Export unmap_mapping_range() wrapper Alex Williamson
2021-03-08 21:48 ` [PATCH v1 04/14] vfio/pci: Use vfio_device_unmap_mapping_range() Alex Williamson
2021-03-08 21:48 ` [PATCH v1 05/14] vfio: Create a vfio_device from vma lookup Alex Williamson
2021-03-08 21:48 ` [PATCH v1 06/14] vfio: Add vma to pfn callback Alex Williamson
2021-03-09 0:33 ` Jason Gunthorpe
2021-03-08 21:48 ` [PATCH v1 07/14] vfio: Add a device notifier interface Alex Williamson
2021-03-09 0:46 ` Jason Gunthorpe
2021-03-09 15:45 ` Alex Williamson
2021-03-09 16:47 ` Jason Gunthorpe
2021-03-10 7:56 ` Christoph Hellwig
2021-03-19 22:25 ` Alex Williamson
2021-03-22 15:16 ` Christoph Hellwig
2021-03-08 21:48 ` [PATCH v1 08/14] vfio/pci: Notify on device release Alex Williamson
2021-03-08 21:48 ` [PATCH v1 09/14] vfio/type1: Refactor pfn_list clearing Alex Williamson
2021-03-10 8:01 ` Christoph Hellwig
2021-03-08 21:49 ` [PATCH v1 10/14] vfio/type1: Pass iommu and dma objects through to vaddr_get_pfn Alex Williamson
2021-03-08 21:49 ` [PATCH v1 11/14] vfio/type1: Register device notifier Alex Williamson
2021-03-10 8:03 ` Christoph Hellwig
2021-03-08 21:49 ` [PATCH v1 12/14] vfio/type1: Support batching of device mappings Alex Williamson
2021-03-09 1:04 ` Jason Gunthorpe
2021-03-08 21:49 ` [PATCH v1 13/14] vfio: Remove extern from declarations across vfio Alex Williamson
2021-03-09 0:21 ` Halil Pasic
2021-03-09 1:07 ` Jason Gunthorpe
2021-03-08 21:49 ` [PATCH v1 14/14] vfio: Cleanup use of bare unsigned Alex Williamson
2021-03-09 1:07 ` Jason Gunthorpe
2021-03-09 8:31 ` Christoph Hellwig
2021-03-09 1:06 ` [PATCH v1 00/14] vfio: Device memory DMA mapping improvements Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46881012f8214a8fa50d1ce2d10c5651@hisilicon.com \
--to=prime.zeng@hisilicon.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).