From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org, linux-imx@nxp.com,
ranjani.sridharan@linux.intel.com,
pierre-louis.bossart@linux.intel.com, shengjiu.wang@nxp.com,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH] ASoC: core: Don't set platform name when of_node is set
Date: Tue, 9 Mar 2021 15:34:55 +0000 [thread overview]
Message-ID: <20210309153455.GB4878@sirena.org.uk> (raw)
In-Reply-To: <20210309082328.38388-1-daniel.baluta@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
>
> Platform may be specified by either name or OF node but not
> both.
>
> For OF node platforms (e.g i.MX) we end up with both platform name
> and of_node set and sound card registration will fail with the error:
>
> asoc-simple-card sof-sound-wm8960: ASoC: Neither/both
> platform name/of_node are set for sai1-wm8960-hifi
This doesn't actually say what the change does.
> - dai_link->platforms->name = component->name;
> +
> + if (!dai_link->platforms->of_node)
> + dai_link->platforms->name = component->name;
Why would we prefer the node name over something explicitly configured?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-09 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 8:23 [PATCH] ASoC: core: Don't set platform name when of_node is set Daniel Baluta
2021-03-09 15:34 ` Mark Brown [this message]
2021-03-12 8:32 ` Daniel Baluta
2021-03-12 10:49 ` Mark Brown
2021-03-12 10:59 ` Daniel Baluta
2021-03-12 11:57 ` Mark Brown
2021-03-12 12:37 ` Daniel Baluta
2021-03-12 14:23 ` Mark Brown
2021-03-17 8:48 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309153455.GB4878@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.baluta@nxp.com \
--cc=daniel.baluta@oss.nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).