Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

From: kernel test robot <lkp@intel.com>
To: Sanket Goswami <Sanket.Goswami@amd.com>,
	jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
	mika.westerberg@linux.intel.com
Cc: kbuild-all@lists.01.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sanket Goswami <Sanket.Goswami@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
Subject: Re: [PATCH] i2c: add i2c bus driver for amd navi gpu
Date: Tue, 9 Mar 2021 22:23:23 +0800	[thread overview]
Message-ID: <202103092236.ex667YlJ-lkp@intel.com> (raw)
In-Reply-To: <20210309133147.1042775-1-Sanket.Goswami@amd.com>

[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]

Hi Sanket,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v5.12-rc2 next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sanket-Goswami/i2c-add-i2c-bus-driver-for-amd-navi-gpu/20210309-213535
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: powerpc64-randconfig-m031-20210309 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f1d0b9c128d45f6d55f3d3f864db2e7ebf42adc5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sanket-Goswami/i2c-add-i2c-bus-driver-for-amd-navi-gpu/20210309-213535
        git checkout f1d0b9c128d45f6d55f3d3f864db2e7ebf42adc5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-designware-master.c:899:5: warning: no previous prototype for 'amd_i2c_adap_quirk' [-Wmissing-prototypes]
     899 | int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
         |     ^~~~~~~~~~~~~~~~~~

vim +/amd_i2c_adap_quirk +899 drivers/i2c/busses/i2c-designware-master.c

   898	
 > 899	int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
   900	{
   901		struct i2c_adapter *amdap = &amdev->adapter;
   902		int ret;
   903	
   904		if (!(amdev->flags & AMD_NON_INTR_MODE))
   905			return -ENODEV;
   906	
   907		return i2c_add_numbered_adapter(amdap);
   908	
   909		return ret;
   910	}
   911	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31856 bytes --]