From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Goswami, Sanket" <Sanket.Goswami@amd.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
Subject: Re: [PATCH] i2c: add i2c bus driver for amd navi gpu
Date: Mon, 29 Mar 2021 15:36:19 +0300 [thread overview]
Message-ID: <YGHJwxBl8igqY6VR@smile.fi.intel.com> (raw)
In-Reply-To: <0ec22c6a-ec19-774d-bcc7-04a7f69c841c@amd.com>
On Mon, Mar 29, 2021 at 11:25:58AM +0530, Goswami, Sanket wrote:
> On 26-Mar-21 16:10, Andy Shevchenko wrote:
> > On Fri, Mar 26, 2021 at 03:53:34PM +0530, Goswami, Sanket wrote:
> >> On 25-Mar-21 22:35, Andy Shevchenko wrote:
> >>> On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote:
> >>>> On 09-Mar-21 19:56, Andy Shevchenko wrote:
> >>>>> On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote:
...
> >>> And I think I already have told you that I prefer to see rather MODEL_ quirk.
> >>
> >> I did not find MODEL_ quirk reference in the PCI device tree, It is actually
> >> used in platform device tree which is completely different from our PCI
> >> based configuration, can you please provide some reference of MODEL_ quirk
> >> which will be part of the PCI device tree?
> >
> > I meant the name of new definition for quirk.
>
> Can you please elaborate this? i am not able to comprehend.
Define in the i2c-designware-core.h something like
#define MODEL_AMD_BLA_BLA_BLA BIT(FOO)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-29 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:31 [PATCH] i2c: add i2c bus driver for amd navi gpu Sanket Goswami
2021-03-09 14:23 ` kernel test robot
2021-03-09 14:26 ` Andy Shevchenko
2021-03-22 16:56 ` Goswami, Sanket
2021-03-25 17:05 ` Andy Shevchenko
2021-03-26 10:23 ` Goswami, Sanket
2021-03-26 10:40 ` Andy Shevchenko
2021-03-29 5:55 ` Goswami, Sanket
2021-03-29 12:36 ` Andy Shevchenko [this message]
2021-03-09 15:35 ` kernel test robot
2021-03-09 15:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGHJwxBl8igqY6VR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Nehal-Bakulchandra.shah@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).