From: Kees Cook <keescook@chromium.org>
To: Jes Sorensen <jes.sorensen@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang
Date: Wed, 10 Mar 2021 11:45:57 -0800 [thread overview]
Message-ID: <202103101141.92165AE@keescook> (raw)
In-Reply-To: <2e425bd8-2722-b8a8-3745-4a3f77771906@gmail.com>
On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
> On 3/10/21 2:14 PM, Kees Cook wrote:
> > On Fri, Mar 05, 2021 at 03:40:33PM +0200, Kalle Valo wrote:
> >> "Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
> >>
> >>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> >>> multiple warnings by replacing /* fall through */ comments with
> >>> the new pseudo-keyword macro fallthrough; instead of letting the
> >>> code fall through to the next case.
> >>>
> >>> Notice that Clang doesn't recognize /* fall through */ comments as
> >>> implicit fall-through markings.
> >>>
> >>> Link: https://github.com/KSPP/linux/issues/115
> >>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> >>
> >> It's not cool that you ignore the comments you got in [1], then after a
> >> while mark the patch as "RESEND" and not even include a changelog why it
> >> was resent.
> >>
> >> [1] https://patchwork.kernel.org/project/linux-wireless/patch/d522f387b2d0dde774785c7169c1f25aa529989d.1605896060.git.gustavoars@kernel.org/
> >
> > Hm, this conversation looks like a miscommunication, mainly? I see
> > Gustavo, as requested by many others[1], replacing the fallthrough
> > comments with the "fallthrough" statement. (This is more than just a
> > "Clang doesn't parse comments" issue.)
> >
> > This could be a tree-wide patch and not bother you, but Greg KH has
> > generally advised us to send these changes broken out. Anyway, this
> > change still needs to land, so what would be the preferred path? I think
> > Gustavo could just carry it for Linus to merge without bothering you if
> > that'd be preferred?
>
> I'll respond with the same I did last time, fallthrough is not C and
> it's ugly.
I understand your point of view, but this is not the consensus[1] of
the community. "fallthrough" is a macro, using the GCC fallthrough
attribute, with the expectation that we can move to the C17/C18
"[[fallthrough]]" statement once it is finalized by the C standards
body.
-Kees
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#implicit-switch-case-fall-through
--
Kees Cook
next prev parent reply other threads:[~2021-03-10 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:48 [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 13:40 ` Kalle Valo
2021-03-05 16:49 ` Gustavo A. R. Silva
2021-03-10 19:14 ` Kees Cook
2021-03-10 19:31 ` Jes Sorensen
2021-03-10 19:45 ` Kees Cook [this message]
2021-03-10 19:51 ` Jes Sorensen
2021-03-10 20:59 ` Kees Cook
2021-04-17 18:29 ` Jes Sorensen
2021-04-17 19:24 ` Gustavo A. R. Silva
2021-04-19 11:58 ` Jes Sorensen
2021-03-11 7:00 ` Kalle Valo
2021-03-11 7:16 ` Gustavo A. R. Silva
2021-04-17 17:52 ` Kalle Valo
[not found] ` <20210417175201.2D5A7C433F1@smtp.codeaurora.org>
2021-04-17 18:30 ` Jes Sorensen
2021-04-18 0:09 ` Joe Perches
2021-04-19 11:56 ` Jes Sorensen
[not found] ` <20210417175201.280F9C4338A@smtp.codeaurora.org>
2021-04-19 22:58 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103101141.92165AE@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=jes.sorensen@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).