linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kexec: Add kexec reboot string
@ 2021-03-04 12:46 Paul Menzel
  2021-03-11  4:09 ` Baoquan He
  2021-03-11  5:32 ` Andrew Morton
  0 siblings, 2 replies; 7+ messages in thread
From: Paul Menzel @ 2021-03-04 12:46 UTC (permalink / raw)
  To: Eric Biederman; +Cc: kexec, linux-kernel, Guohan Lu, Joe LeVeque, Paul Menzel

From: Joe LeVeque <jolevequ@microsoft.com>

The purpose is to notify the kernel module for fast reboot.

Upstream a patch from the SONiC network operating system [1].

[1]: https://github.com/Azure/sonic-linux-kernel/pull/46

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 kernel/kexec_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index a0b6780740c8..f04d04d1b855 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -1165,7 +1165,7 @@ int kernel_kexec(void)
 #endif
 	{
 		kexec_in_progress = true;
-		kernel_restart_prepare(NULL);
+		kernel_restart_prepare("kexec reboot");
 		migrate_to_reboot_cpu();
 
 		/*
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] kexec: Add kexec reboot string
  2021-03-04 12:46 [PATCH] kexec: Add kexec reboot string Paul Menzel
@ 2021-03-11  4:09 ` Baoquan He
  2021-03-11  5:32 ` Andrew Morton
  1 sibling, 0 replies; 7+ messages in thread
From: Baoquan He @ 2021-03-11  4:09 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Eric Biederman, kexec, linux-kernel, Guohan Lu, Joe LeVeque, akpm

On 03/04/21 at 01:46pm, Paul Menzel wrote:
> From: Joe LeVeque <jolevequ@microsoft.com>
> 
> The purpose is to notify the kernel module for fast reboot.

Checked several modules which registered with reboot_notifier_list, the
passed string is not cared. Just curious, could you tell how you have
used or plan to use this string in your code?

No objection to this even though it's trivial if no real use case.

Acked-by: Baoquan He <bhe@redhat.com>

> 
> Upstream a patch from the SONiC network operating system [1].
> 
> [1]: https://github.com/Azure/sonic-linux-kernel/pull/46
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  kernel/kexec_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index a0b6780740c8..f04d04d1b855 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1165,7 +1165,7 @@ int kernel_kexec(void)
>  #endif
>  	{
>  		kexec_in_progress = true;
> -		kernel_restart_prepare(NULL);
> +		kernel_restart_prepare("kexec reboot");
>  		migrate_to_reboot_cpu();
>  
>  		/*
> -- 
> 2.30.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] kexec: Add kexec reboot string
  2021-03-04 12:46 [PATCH] kexec: Add kexec reboot string Paul Menzel
  2021-03-11  4:09 ` Baoquan He
@ 2021-03-11  5:32 ` Andrew Morton
  2021-03-11 18:14   ` [EXTERNAL] " Joe LeVeque
  1 sibling, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2021-03-11  5:32 UTC (permalink / raw)
  To: Paul Menzel; +Cc: Eric Biederman, kexec, linux-kernel, Guohan Lu, Joe LeVeque

On Thu,  4 Mar 2021 13:46:26 +0100 Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> From: Joe LeVeque <jolevequ@microsoft.com>
> 
> The purpose is to notify the kernel module for fast reboot.
> 
> Upstream a patch from the SONiC network operating system [1].
> 
> [1]: https://github.com/Azure/sonic-linux-kernel/pull/46
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

We should have Joe's signed-off-by: for this.  Joe, can you please send
it?


^ permalink raw reply	[flat|nested] 7+ messages in thread
* RE: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string
  2021-03-11  5:32 ` Andrew Morton
@ 2021-03-11 18:14   ` Joe LeVeque
  2021-03-11 20:53     ` Andrew Morton
  2021-03-11 21:07     ` Paul Menzel
  0 siblings, 2 replies; 7+ messages in thread
From: Joe LeVeque @ 2021-03-11 18:14 UTC (permalink / raw)
  To: Andrew Morton, Paul Menzel; +Cc: Eric Biederman, kexec, linux-kernel, Guohan Lu

Hi Andrew,

Is this all your looking for? If not, please let me know.

> Signed-off-by: Joe LeVeque <jolevequ@microsoft.com>

Thanks,
Joe

-----Original Message-----
From: Andrew Morton <akpm@linux-foundation.org> 
Sent: Wednesday, March 10, 2021 9:33 PM
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Eric Biederman <ebiederm@xmission.com>; kexec@lists.infradead.org; linux-kernel@vger.kernel.org; Guohan Lu <lguohan@gmail.com>; Joe LeVeque <jolevequ@microsoft.com>
Subject: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string

On Thu,  4 Mar 2021 13:46:26 +0100 Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> From: Joe LeVeque <jolevequ@microsoft.com>
> 
> The purpose is to notify the kernel module for fast reboot.
> 
> Upstream a patch from the SONiC network operating system [1].
> 
> [1]: 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2FAzure%2Fsonic-linux-kernel%2Fpull%2F46&amp;data=04%7C01%7Cjol
> evequ%40microsoft.com%7Cddd7ea68d7d14ecdbd6608d8e44f225b%7C72f988bf86f
> 141af91ab2d7cd011db47%7C1%7C0%7C637510375952624615%7CUnknown%7CTWFpbGZ
> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C1000&amp;sdata=0lxaoVz%2BYyu5C4HvzSGMf0NpJJUWZFWdp7m3hLlL9MM%3D&am
> p;reserved=0
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

We should have Joe's signed-off-by: for this.  Joe, can you please send it?


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string
  2021-03-11 18:14   ` [EXTERNAL] " Joe LeVeque
@ 2021-03-11 20:53     ` Andrew Morton
  2021-03-11 21:07     ` Paul Menzel
  1 sibling, 0 replies; 7+ messages in thread
From: Andrew Morton @ 2021-03-11 20:53 UTC (permalink / raw)
  To: Joe LeVeque; +Cc: Paul Menzel, Eric Biederman, kexec, linux-kernel, Guohan Lu

On Thu, 11 Mar 2021 18:14:19 +0000 Joe LeVeque <jolevequ@microsoft.com> wrote:

> Is this all your looking for? If not, please let me know.
> 
> > Signed-off-by: Joe LeVeque <jolevequ@microsoft.com>

Yes, thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string
  2021-03-11 18:14   ` [EXTERNAL] " Joe LeVeque
  2021-03-11 20:53     ` Andrew Morton
@ 2021-03-11 21:07     ` Paul Menzel
  1 sibling, 0 replies; 7+ messages in thread
From: Paul Menzel @ 2021-03-11 21:07 UTC (permalink / raw)
  To: Joe LeVeque, Andrew Morton; +Cc: Eric Biederman, kexec, linux-kernel, Guohan Lu

Dear Joe,


Thank you for replying.


Am 11.03.21 um 19:14 schrieb Joe LeVeque:

> Is this all your looking for? If not, please let me know.
> 
>> Signed-off-by: Joe LeVeque <jolevequ@microsoft.com>

It’d be great if you answered Baoquan He’s question, how it’s actually 
used in SONiC. (I just sent the patch upstream to reduce the out-of-tree 
patches in SONiC.)


Kind regards,

Paul

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] kexec: Add kexec reboot string
@ 2020-11-03 13:40 Paul Menzel
  0 siblings, 0 replies; 7+ messages in thread
From: Paul Menzel @ 2020-11-03 13:40 UTC (permalink / raw)
  To: Eric Biederman; +Cc: Joe LeVeque, kexec, linux-kernel, Paul Menzel

From: Joe LeVeque <jolevequ@microsoft.com>

The purpose is to notify the kernel module for fast reboot.

Upstream a patch from the SONiC network operating system [1].

[1]: https://github.com/Azure/sonic-linux-kernel/pull/46

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 kernel/kexec_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 8798a8183974..9aaa6ce48cdf 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -1167,7 +1167,7 @@ int kernel_kexec(void)
 #endif
 	{
 		kexec_in_progress = true;
-		kernel_restart_prepare(NULL);
+		kernel_restart_prepare("kexec reboot");
 		migrate_to_reboot_cpu();
 
 		/*
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-11 21:08 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 12:46 [PATCH] kexec: Add kexec reboot string Paul Menzel
2021-03-11  4:09 ` Baoquan He
2021-03-11  5:32 ` Andrew Morton
2021-03-11 18:14   ` [EXTERNAL] " Joe LeVeque
2021-03-11 20:53     ` Andrew Morton
2021-03-11 21:07     ` Paul Menzel
  -- strict thread matches above, loose matches on Subject: below --
2020-11-03 13:40 Paul Menzel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).