* [PATCH] scsi: Fix a double free in myrs_cleanup
@ 2021-03-11 6:30 Lv Yunlong
2021-03-11 10:43 ` Hannes Reinecke
2021-03-16 3:13 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Lv Yunlong @ 2021-03-11 6:30 UTC (permalink / raw)
To: hare, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, Lv Yunlong
In myrs_cleanup, cs->mmio_base will be freed twice by
iounmap().
Fixes: 77266186397c6 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
---
drivers/scsi/myrs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
index 4adf9ded296a..329fd025c718 100644
--- a/drivers/scsi/myrs.c
+++ b/drivers/scsi/myrs.c
@@ -2273,12 +2273,12 @@ static void myrs_cleanup(struct myrs_hba *cs)
if (cs->mmio_base) {
cs->disable_intr(cs);
iounmap(cs->mmio_base);
+ cs->mmio_base = NULL;
}
if (cs->irq)
free_irq(cs->irq, cs);
if (cs->io_addr)
release_region(cs->io_addr, 0x80);
- iounmap(cs->mmio_base);
pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
scsi_host_put(cs->host);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: Fix a double free in myrs_cleanup
2021-03-11 6:30 [PATCH] scsi: Fix a double free in myrs_cleanup Lv Yunlong
@ 2021-03-11 10:43 ` Hannes Reinecke
2021-03-16 3:13 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2021-03-11 10:43 UTC (permalink / raw)
To: Lv Yunlong, hare, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
On 3/11/21 7:30 AM, Lv Yunlong wrote:
> In myrs_cleanup, cs->mmio_base will be freed twice by
> iounmap().
>
> Fixes: 77266186397c6 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
> ---
> drivers/scsi/myrs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
> index 4adf9ded296a..329fd025c718 100644
> --- a/drivers/scsi/myrs.c
> +++ b/drivers/scsi/myrs.c
> @@ -2273,12 +2273,12 @@ static void myrs_cleanup(struct myrs_hba *cs)
> if (cs->mmio_base) {
> cs->disable_intr(cs);
> iounmap(cs->mmio_base);
> + cs->mmio_base = NULL;
> }
> if (cs->irq)
> free_irq(cs->irq, cs);
> if (cs->io_addr)
> release_region(cs->io_addr, 0x80);
> - iounmap(cs->mmio_base);
> pci_set_drvdata(pdev, NULL);
> pci_disable_device(pdev);
> scsi_host_put(cs->host);
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: Fix a double free in myrs_cleanup
2021-03-11 6:30 [PATCH] scsi: Fix a double free in myrs_cleanup Lv Yunlong
2021-03-11 10:43 ` Hannes Reinecke
@ 2021-03-16 3:13 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-03-16 3:13 UTC (permalink / raw)
To: hare, jejb, Lv Yunlong; +Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Wed, 10 Mar 2021 22:30:05 -0800, Lv Yunlong wrote:
> In myrs_cleanup, cs->mmio_base will be freed twice by
> iounmap().
Applied to 5.12/scsi-fixes, thanks!
[1/1] scsi: Fix a double free in myrs_cleanup
https://git.kernel.org/mkp/scsi/c/2bb817712e2f
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-16 3:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 6:30 [PATCH] scsi: Fix a double free in myrs_cleanup Lv Yunlong
2021-03-11 10:43 ` Hannes Reinecke
2021-03-16 3:13 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).