linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] init: do_mounts.c: Fix indentation errors.
@ 2021-03-11 12:06 Shubhankar Kuranagatti
  2021-03-11 12:27 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Shubhankar Kuranagatti @ 2021-03-11 12:06 UTC (permalink / raw)
  To: axboe; +Cc: jack, hare, gregkh, tj, linux-kernel

Switch and case have been aligned together, extra tab removed
Removed extra space before tab.

Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
---
 init/do_mounts.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index a78e44ee6adb..82fe66d2eb97 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -422,13 +422,13 @@ void __init mount_block_root(char *name, int flags)
 	for (p = fs_names; *p; p += strlen(p)+1) {
 		int err = do_mount_root(name, p, flags, root_mount_data);
 		switch (err) {
-			case 0:
-				goto out;
-			case -EACCES:
-			case -EINVAL:
-				continue;
+		case 0:
+			goto out;
+		case -EACCES:
+		case -EINVAL:
+			continue;
 		}
-	        /*
+		/*
 		 * Allow the user to distinguish between failed sys_open
 		 * and bad superblock on root device.
 		 * and give them a list of the available devices
@@ -459,7 +459,6 @@ void __init mount_block_root(char *name, int flags)
 out:
 	put_page(page);
 }
- 
 #ifdef CONFIG_ROOT_NFS
 
 #define NFSROOT_TIMEOUT_MIN	5
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] init: do_mounts.c: Fix indentation errors.
  2021-03-11 12:06 [PATCH] init: do_mounts.c: Fix indentation errors Shubhankar Kuranagatti
@ 2021-03-11 12:27 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-03-11 12:27 UTC (permalink / raw)
  To: Shubhankar Kuranagatti; +Cc: axboe, jack, hare, tj, linux-kernel

On Thu, Mar 11, 2021 at 05:36:50PM +0530, Shubhankar Kuranagatti wrote:
> Switch and case have been aligned together, extra tab removed
> Removed extra space before tab.
> 
> Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
> ---
>  init/do_mounts.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

For basic "clean up the code as a first patch task", please stick to the
code under drivers/staging/ and do not venture out into the "core"
kernel files as that just causes unneeded and unwanted churn.

good luck!

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-11 12:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 12:06 [PATCH] init: do_mounts.c: Fix indentation errors Shubhankar Kuranagatti
2021-03-11 12:27 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).