* [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
@ 2021-03-12 23:26 Bhaskar Chowdhury
2021-03-13 0:16 ` Tom Saeger
0 siblings, 1 reply; 6+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-12 23:26 UTC (permalink / raw)
To: rjw, viresh.kumar, krzk, linux-pm, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
s/untile/until/
s/souce/source/
s/divier/divider/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
Changes from V1:
Krzysztof spotted a grammatical flaw left over ...so corrected..
drivers/cpufreq/s5pv210-cpufreq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index 69786e5bbf05..af1ac3f6e4b8 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -378,7 +378,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
/*
* 6. Turn on APLL
* 6-1. Set PMS values
- * 6-2. Wait untile the PLL is locked
+ * 6-2. Wait until the PLL is locked
*/
if (index == L0)
writel_relaxed(APLL_VAL_1000, S5P_APLL_CON);
@@ -390,7 +390,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
} while (!(reg & (0x1 << 29)));
/*
- * 7. Change souce clock from SCLKMPLL(667Mhz)
+ * 7. Change source clock from SCLKMPLL(667Mhz)
* to SCLKA2M(200Mhz) in MFC_MUX and G3D MUX
* (667/4=166)->(200/4=50)Mhz
*/
@@ -439,7 +439,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
}
/*
- * L4 level need to change memory bus speed, hence onedram clock divier
+ * L4 level needs to change memory bus speed, hence onedram clock divider
* and memory refresh parameter should be changed
*/
if (bus_speed_changing) {
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
2021-03-12 23:26 [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c Bhaskar Chowdhury
@ 2021-03-13 0:16 ` Tom Saeger
2021-03-13 0:50 ` Bhaskar Chowdhury
0 siblings, 1 reply; 6+ messages in thread
From: Tom Saeger @ 2021-03-13 0:16 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: rjw, viresh.kumar, krzk, linux-pm, linux-arm-kernel,
linux-samsung-soc, linux-kernel, rdunlap
On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote:
sent a few additional typo fixes to your V1, can you add those to your patch?
Regards,
--Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
2021-03-13 0:16 ` Tom Saeger
@ 2021-03-13 0:50 ` Bhaskar Chowdhury
2021-03-13 0:57 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-13 0:50 UTC (permalink / raw)
To: Tom Saeger
Cc: rjw, viresh.kumar, krzk, linux-pm, linux-arm-kernel,
linux-samsung-soc, linux-kernel, rdunlap
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On 17:16 Fri 12 Mar 2021, Tom Saeger wrote:
>On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote:
>
>sent a few additional typo fixes to your V1, can you add those to your patch?
>
>Regards,
>
>--Tom
Thanks, I have already sent out a V2 in public...I might make a V3 with your
changes too...did you sent it to ???
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
2021-03-13 0:50 ` Bhaskar Chowdhury
@ 2021-03-13 0:57 ` Randy Dunlap
2021-03-13 2:59 ` Tom Saeger
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2021-03-13 0:57 UTC (permalink / raw)
To: Bhaskar Chowdhury, Tom Saeger, rjw, viresh.kumar, krzk, linux-pm,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On 3/12/21 4:50 PM, Bhaskar Chowdhury wrote:
> On 17:16 Fri 12 Mar 2021, Tom Saeger wrote:
>> On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote:
>>
>> sent a few additional typo fixes to your V1, can you add those to your patch?
>>
>> Regards,
>>
>> --Tom
>
> Thanks, I have already sent out a V2 in public...I might make a V3 with your
> changes too...did you sent it to ???
It was just a reply to your v1 patch.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
2021-03-13 0:57 ` Randy Dunlap
@ 2021-03-13 2:59 ` Tom Saeger
2021-03-13 3:52 ` Bhaskar Chowdhury
0 siblings, 1 reply; 6+ messages in thread
From: Tom Saeger @ 2021-03-13 2:59 UTC (permalink / raw)
To: Randy Dunlap
Cc: Bhaskar Chowdhury, rjw, viresh.kumar, krzk, linux-pm,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On Fri, Mar 12, 2021 at 04:57:07PM -0800, Randy Dunlap wrote:
> On 3/12/21 4:50 PM, Bhaskar Chowdhury wrote:
> > On 17:16 Fri 12 Mar 2021, Tom Saeger wrote:
> >> On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote:
> >>
> >> sent a few additional typo fixes to your V1, can you add those to your patch?
> >>
> >> Regards,
> >>
> >> --Tom
> >
> > Thanks, I have already sent out a V2 in public...I might make a V3 with your
> > changes too...did you sent it to ???
>
> It was just a reply to your v1 patch.
>
> --
> ~Randy
>
Bhaskar,
Here you go...
V2 additions:
diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index af1ac3f6e4b8..73110b005716 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -91,7 +91,7 @@ static DEFINE_MUTEX(set_freq_lock);
/* Use 800MHz when entering sleep mode */
#define SLEEP_FREQ (800 * 1000)
-/* Tracks if cpu freqency can be updated anymore */
+/* Tracks if cpu frequency can be updated anymore */
static bool no_cpufreq_access;
/*
@@ -190,7 +190,7 @@ static u32 clkdiv_val[5][11] = {
/*
* This function set DRAM refresh counter
- * accoriding to operating frequency of DRAM
+ * according to operating frequency of DRAM
* ch: DMC port number 0 or 1
* freq: Operating frequency of DRAM(KHz)
*/
@@ -320,7 +320,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
/*
* 3. DMC1 refresh count for 133Mhz if (index == L4) is
- * true refresh counter is already programed in upper
+ * true refresh counter is already programmed in upper
* code. 0x287@83Mhz
*/
if (!bus_speed_changing)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
2021-03-13 2:59 ` Tom Saeger
@ 2021-03-13 3:52 ` Bhaskar Chowdhury
0 siblings, 0 replies; 6+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-13 3:52 UTC (permalink / raw)
To: Tom Saeger
Cc: Randy Dunlap, rjw, viresh.kumar, krzk, linux-pm,
linux-arm-kernel, linux-samsung-soc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]
On 19:59 Fri 12 Mar 2021, Tom Saeger wrote:
>On Fri, Mar 12, 2021 at 04:57:07PM -0800, Randy Dunlap wrote:
>> On 3/12/21 4:50 PM, Bhaskar Chowdhury wrote:
>> > On 17:16 Fri 12 Mar 2021, Tom Saeger wrote:
>> >> On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote:
>> >>
>> >> sent a few additional typo fixes to your V1, can you add those to your patch?
>> >>
>> >> Regards,
>> >>
>> >> --Tom
>> >
>> > Thanks, I have already sent out a V2 in public...I might make a V3 with your
>> > changes too...did you sent it to ???
>>
>> It was just a reply to your v1 patch.
>>
>> --
>> ~Randy
>>
>
>Bhaskar,
>
>Here you go...
>
>V2 additions:
>
>diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
>index af1ac3f6e4b8..73110b005716 100644
>--- a/drivers/cpufreq/s5pv210-cpufreq.c
>+++ b/drivers/cpufreq/s5pv210-cpufreq.c
>@@ -91,7 +91,7 @@ static DEFINE_MUTEX(set_freq_lock);
> /* Use 800MHz when entering sleep mode */
> #define SLEEP_FREQ (800 * 1000)
>
>-/* Tracks if cpu freqency can be updated anymore */
>+/* Tracks if cpu frequency can be updated anymore */
> static bool no_cpufreq_access;
>
> /*
>@@ -190,7 +190,7 @@ static u32 clkdiv_val[5][11] = {
>
> /*
> * This function set DRAM refresh counter
>- * accoriding to operating frequency of DRAM
>+ * according to operating frequency of DRAM
> * ch: DMC port number 0 or 1
> * freq: Operating frequency of DRAM(KHz)
> */
>@@ -320,7 +320,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
>
> /*
> * 3. DMC1 refresh count for 133Mhz if (index == L4) is
>- * true refresh counter is already programed in upper
>+ * true refresh counter is already programmed in upper
> * code. 0x287@83Mhz
> */
> if (!bus_speed_changing)
>
Tom,
I sent out an V3 incorporated with your findings.
Thanks,
Bhaskar
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-13 4:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 23:26 [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c Bhaskar Chowdhury
2021-03-13 0:16 ` Tom Saeger
2021-03-13 0:50 ` Bhaskar Chowdhury
2021-03-13 0:57 ` Randy Dunlap
2021-03-13 2:59 ` Tom Saeger
2021-03-13 3:52 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).