* [PATCH] staging: octeon-usb: fixed precedence issue
@ 2021-03-13 17:32 Selvakumar Elangovan
2021-03-14 7:33 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Selvakumar Elangovan @ 2021-03-13 17:32 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
Added parenthesis around reg macro to avoid precedence issue identified by
checkpatch.pl
Signed-off-by: Selvakumar Elangovan <selvakumar16197@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
index 9ed619c93a4e..5aefd3fb3854 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.h
+++ b/drivers/staging/octeon-usb/octeon-hcd.h
@@ -51,11 +51,11 @@
#include <asm/bitfield.h>
#define CVMX_USBCXBASE 0x00016F0010000000ull
-#define CVMX_USBCXREG1(reg, bid) \
- (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | reg) + \
+#define CVMX_USBCXREG1((reg), bid) \
+ (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | (reg)) + \
((bid) & 1) * 0x100000000000ull)
-#define CVMX_USBCXREG2(reg, bid, off) \
- (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | reg) + \
+#define CVMX_USBCXREG2((reg), bid, off) \
+ (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | (reg)) + \
(((off) & 7) + ((bid) & 1) * 0x8000000000ull) * 32)
#define CVMX_USBCX_GAHBCFG(bid) CVMX_USBCXREG1(0x008, bid)
@@ -86,10 +86,10 @@
#define CVMX_USBNXBID1(bid) (((bid) & 1) * 0x10000000ull)
#define CVMX_USBNXBID2(bid) (((bid) & 1) * 0x100000000000ull)
-#define CVMX_USBNXREG1(reg, bid) \
- (CVMX_ADD_IO_SEG(0x0001180068000000ull | reg) + CVMX_USBNXBID1(bid))
-#define CVMX_USBNXREG2(reg, bid) \
- (CVMX_ADD_IO_SEG(0x00016F0000000000ull | reg) + CVMX_USBNXBID2(bid))
+#define CVMX_USBNXREG1((reg), bid) \
+ (CVMX_ADD_IO_SEG(0x0001180068000000ull | (reg)) + CVMX_USBNXBID1(bid))
+#define CVMX_USBNXREG2((reg), bid) \
+ (CVMX_ADD_IO_SEG(0x00016F0000000000ull | (reg)) + CVMX_USBNXBID2(bid))
#define CVMX_USBNX_CLK_CTL(bid) CVMX_USBNXREG1(0x10, bid)
#define CVMX_USBNX_DMA0_INB_CHN0(bid) CVMX_USBNXREG2(0x818, bid)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: octeon-usb: fixed precedence issue
2021-03-13 17:32 [PATCH] staging: octeon-usb: fixed precedence issue Selvakumar Elangovan
@ 2021-03-14 7:33 ` Greg KH
[not found] ` <CAD=cR88u5o58NaL=z6NtMc2=N-hesKkFC8tkP3PJ4fu1Oaf-ZQ@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-03-14 7:33 UTC (permalink / raw)
To: Selvakumar Elangovan; +Cc: devel, linux-kernel
On Sat, Mar 13, 2021 at 11:02:47PM +0530, Selvakumar Elangovan wrote:
> Added parenthesis around reg macro to avoid precedence issue identified by
> checkpatch.pl
>
> Signed-off-by: Selvakumar Elangovan <selvakumar16197@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
> index 9ed619c93a4e..5aefd3fb3854 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.h
> +++ b/drivers/staging/octeon-usb/octeon-hcd.h
> @@ -51,11 +51,11 @@
> #include <asm/bitfield.h>
>
> #define CVMX_USBCXBASE 0x00016F0010000000ull
> -#define CVMX_USBCXREG1(reg, bid) \
> - (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | reg) + \
> +#define CVMX_USBCXREG1((reg), bid) \
Why did you change this line?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: octeon-usb: fixed precedence issue
[not found] ` <CAD=cR88u5o58NaL=z6NtMc2=N-hesKkFC8tkP3PJ4fu1Oaf-ZQ@mail.gmail.com>
@ 2021-03-14 8:35 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-03-14 8:35 UTC (permalink / raw)
To: Selvakumar E; +Cc: devel, linux-kernel
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sun, Mar 14, 2021 at 01:34:23PM +0530, Selvakumar E wrote:
> Hi Greg
> I changed the line because of the checkpatch.pl warned for
> precedence issue.
But I fail to see how this:
> > > +#define CVMX_USBCXREG1((reg), bid) \
Does anything here at all.
What am I missing?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-14 8:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 17:32 [PATCH] staging: octeon-usb: fixed precedence issue Selvakumar Elangovan
2021-03-14 7:33 ` Greg KH
[not found] ` <CAD=cR88u5o58NaL=z6NtMc2=N-hesKkFC8tkP3PJ4fu1Oaf-ZQ@mail.gmail.com>
2021-03-14 8:35 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).