From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH v2 01/18] media: i2c: rdamc21: Fix warning on u8 cast
Date: Mon, 15 Mar 2021 14:14:55 +0100 [thread overview]
Message-ID: <20210315131512.133720-2-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20210315131512.133720-1-jacopo+renesas@jmondi.org>
Sparse reports a warning on a cast to u8 of a 16 bits constant.
drivers/media/i2c/rdacm21.c:348:62: warning: cast truncates bits
from constant value (300a becomes a)
Even if the behaviour is intended, silence the sparse warning replacing
the cast with a bitwise & operation.
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/media/i2c/rdacm21.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
index dcc21515e5a4..179d107f494c 100644
--- a/drivers/media/i2c/rdacm21.c
+++ b/drivers/media/i2c/rdacm21.c
@@ -345,7 +345,7 @@ static int ov10640_initialize(struct rdacm21_device *dev)
/* Read OV10640 ID to test communications. */
ov490_write_reg(dev, OV490_SCCB_SLAVE0_DIR, OV490_SCCB_SLAVE_READ);
ov490_write_reg(dev, OV490_SCCB_SLAVE0_ADDR_HIGH, OV10640_CHIP_ID >> 8);
- ov490_write_reg(dev, OV490_SCCB_SLAVE0_ADDR_LOW, (u8)OV10640_CHIP_ID);
+ ov490_write_reg(dev, OV490_SCCB_SLAVE0_ADDR_LOW, OV10640_CHIP_ID & 0xff);
/* Trigger SCCB slave transaction and give it some time to complete. */
ov490_write_reg(dev, OV490_HOST_CMD, OV490_HOST_CMD_TRIGGER);
--
2.30.0
next prev parent reply other threads:[~2021-03-15 13:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 13:14 [PATCH v2 00/18] media: gmsl: Reliability improvement Jacopo Mondi
2021-03-15 13:14 ` Jacopo Mondi [this message]
2021-03-15 15:27 ` [PATCH v2 01/18] media: i2c: rdamc21: Fix warning on u8 cast Kieran Bingham
2021-03-15 21:35 ` Laurent Pinchart
2021-03-15 13:14 ` [PATCH v2 02/18] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-03-15 21:37 ` Laurent Pinchart
2021-03-16 12:56 ` Jacopo Mondi
2021-03-16 19:24 ` Laurent Pinchart
2021-03-15 13:14 ` [PATCH v2 03/18] media: i2c: rdacm20: Embedded 'serializer' field Jacopo Mondi
2021-03-15 15:29 ` Kieran Bingham
2021-03-15 13:14 ` [PATCH v2 04/18] media: i2c: rdacm20: Replace goto with a loop Jacopo Mondi
2021-03-15 15:36 ` Kieran Bingham
2021-03-15 13:14 ` [PATCH v2 05/18] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 06/18] media: i2c: max9271: Check max9271_write() return Jacopo Mondi
2021-03-15 15:46 ` Kieran Bingham
2021-03-15 21:38 ` Laurent Pinchart
2021-03-15 13:15 ` [PATCH v2 07/18] media: i2c: rdacm20: Check return values Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 08/18] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 09/18] media: i2c: max9271: Introduce wake_up() function Jacopo Mondi
2021-03-15 17:14 ` Kieran Bingham
2021-03-15 21:43 ` Laurent Pinchart
2021-03-15 13:15 ` [PATCH v2 10/18] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 11/18] media: i2c: rdacm21: Fix OV10640 powerdown Jacopo Mondi
2021-03-15 17:20 ` Kieran Bingham
2021-03-15 21:45 ` Laurent Pinchart
2021-03-15 13:15 ` [PATCH v2 12/18] media: i2c: rdacm21: Give more time to OV490 to boot Jacopo Mondi
2021-03-15 17:22 ` Kieran Bingham
2021-03-17 10:04 ` Jacopo Mondi
2021-03-19 0:29 ` Laurent Pinchart
2021-03-19 14:53 ` Jacopo Mondi
2021-03-15 21:52 ` Laurent Pinchart
2021-03-15 13:15 ` [PATCH v2 13/18] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 14/18] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 15/18] media: i2c: max9286: Define high " Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 16/18] media: v4l2-subdev: De-deprecate init() subdev op Jacopo Mondi
2021-03-15 21:56 ` Laurent Pinchart
2021-03-15 13:15 ` [PATCH v2 17/18] media: gmsl: Reimplement initialization sequence Jacopo Mondi
2021-03-15 13:15 ` [PATCH v2 18/18] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-03-15 17:28 ` Kieran Bingham
2021-03-15 21:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315131512.133720-2-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=geert@linux-m68k.org \
--cc=hverkuil@xs4all.nl \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).