From: Kees Cook <keescook@chromium.org>
To: menglong8.dong@gmail.com
Cc: ebiederm@xmission.com, gustavoars@kernel.org,
viro@zeniv.linux.org.uk, zhang.yunkai@zte.com.cn, pcc@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signal: remove duplicate include in signal.h
Date: Mon, 15 Mar 2021 13:47:02 -0700 [thread overview]
Message-ID: <202103151346.F7FE09F43D@keescook> (raw)
In-Reply-To: <20210313111108.366380-1-zhang.yunkai@zte.com.cn>
On Sat, Mar 13, 2021 at 03:11:08AM -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/string.h' included in 'signal.h' is duplicated.
> It is also included in the 7th line.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> include/linux/signal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/signal.h b/include/linux/signal.h
> index 205526c4003a..c371d3a3ff61 100644
> --- a/include/linux/signal.h
> +++ b/include/linux/signal.h
> @@ -124,7 +124,6 @@ static inline int sigequalsets(const sigset_t *set1, const sigset_t *set2)
> #define sigmask(sig) (1UL << ((sig) - 1))
>
> #ifndef __HAVE_ARCH_SIG_SETOPS
> -#include <linux/string.h>
>
> #define _SIG_SET_BINOP(name, op) \
> static inline void name(sigset_t *r, const sigset_t *a, const sigset_t *b) \
> --
> 2.25.1
>
--
Kees Cook
next prev parent reply other threads:[~2021-03-15 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 11:11 [PATCH] signal: remove duplicate include in signal.h menglong8.dong
2021-03-15 20:47 ` Kees Cook [this message]
2021-10-19 2:49 cgel.zte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103151346.F7FE09F43D@keescook \
--to=keescook@chromium.org \
--cc=ebiederm@xmission.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=pcc@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).