* [PATCH] signal: remove duplicate include in signal.h
@ 2021-03-13 11:11 menglong8.dong
2021-03-15 20:47 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: menglong8.dong @ 2021-03-13 11:11 UTC (permalink / raw)
To: ebiederm; +Cc: gustavoars, viro, keescook, zhang.yunkai, pcc, linux-kernel
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
'linux/string.h' included in 'signal.h' is duplicated.
It is also included in the 7th line.
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
include/linux/signal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/signal.h b/include/linux/signal.h
index 205526c4003a..c371d3a3ff61 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -124,7 +124,6 @@ static inline int sigequalsets(const sigset_t *set1, const sigset_t *set2)
#define sigmask(sig) (1UL << ((sig) - 1))
#ifndef __HAVE_ARCH_SIG_SETOPS
-#include <linux/string.h>
#define _SIG_SET_BINOP(name, op) \
static inline void name(sigset_t *r, const sigset_t *a, const sigset_t *b) \
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] signal: remove duplicate include in signal.h
2021-03-13 11:11 [PATCH] signal: remove duplicate include in signal.h menglong8.dong
@ 2021-03-15 20:47 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2021-03-15 20:47 UTC (permalink / raw)
To: menglong8.dong
Cc: ebiederm, gustavoars, viro, zhang.yunkai, pcc, linux-kernel
On Sat, Mar 13, 2021 at 03:11:08AM -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/string.h' included in 'signal.h' is duplicated.
> It is also included in the 7th line.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> include/linux/signal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/signal.h b/include/linux/signal.h
> index 205526c4003a..c371d3a3ff61 100644
> --- a/include/linux/signal.h
> +++ b/include/linux/signal.h
> @@ -124,7 +124,6 @@ static inline int sigequalsets(const sigset_t *set1, const sigset_t *set2)
> #define sigmask(sig) (1UL << ((sig) - 1))
>
> #ifndef __HAVE_ARCH_SIG_SETOPS
> -#include <linux/string.h>
>
> #define _SIG_SET_BINOP(name, op) \
> static inline void name(sigset_t *r, const sigset_t *a, const sigset_t *b) \
> --
> 2.25.1
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] signal: remove duplicate include in signal.h
@ 2021-10-19 2:49 cgel.zte
0 siblings, 0 replies; 3+ messages in thread
From: cgel.zte @ 2021-10-19 2:49 UTC (permalink / raw)
To: ebiederm
Cc: elver, peterz, oleg, akpm, tglx, gustavoars, pcc, viro,
ye.guojin, linux-kernel, Zeal Robot
From: Ye Guojin <ye.guojin@zte.com.cn>
'linux/string.h' included in 'signal.h' is duplicated.
it's also included at line 7.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
---
include/linux/signal.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/signal.h b/include/linux/signal.h
index 3f96a6374e4f..37f5080c070a 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -126,7 +126,6 @@ static inline int sigequalsets(const sigset_t *set1, const sigset_t *set2)
#define sigmask(sig) (1UL << ((sig) - 1))
#ifndef __HAVE_ARCH_SIG_SETOPS
-#include <linux/string.h>
#define _SIG_SET_BINOP(name, op) \
static inline void name(sigset_t *r, const sigset_t *a, const sigset_t *b) \
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19 2:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 11:11 [PATCH] signal: remove duplicate include in signal.h menglong8.dong
2021-03-15 20:47 ` Kees Cook
2021-10-19 2:49 cgel.zte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).