* [PATCH net-next] net: cdc_ncm: drop redundant driver-data assignment
@ 2021-03-18 16:01 Johan Hovold
2021-03-19 2:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2021-03-18 16:01 UTC (permalink / raw)
To: Oliver Neukum, David S. Miller, Jakub Kicinski
Cc: linux-usb, netdev, linux-kernel, Johan Hovold
The driver data for the data interface has already been set by
usb_driver_claim_interface() so drop the subsequent redundant
assignment.
Note that this also avoids setting the driver data three times in case
of a combined interface.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/net/usb/cdc_ncm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 8acf30115428..8ae565a801b5 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -920,7 +920,6 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_
goto error2;
}
- usb_set_intfdata(ctx->data, dev);
usb_set_intfdata(ctx->control, dev);
if (ctx->ether_desc) {
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: cdc_ncm: drop redundant driver-data assignment
2021-03-18 16:01 [PATCH net-next] net: cdc_ncm: drop redundant driver-data assignment Johan Hovold
@ 2021-03-19 2:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-19 2:20 UTC (permalink / raw)
To: Johan Hovold; +Cc: oneukum, davem, kuba, linux-usb, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Thu, 18 Mar 2021 17:01:42 +0100 you wrote:
> The driver data for the data interface has already been set by
> usb_driver_claim_interface() so drop the subsequent redundant
> assignment.
>
> Note that this also avoids setting the driver data three times in case
> of a combined interface.
>
> [...]
Here is the summary with links:
- [net-next] net: cdc_ncm: drop redundant driver-data assignment
https://git.kernel.org/netdev/net-next/c/269aa0301224
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-19 2:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 16:01 [PATCH net-next] net: cdc_ncm: drop redundant driver-data assignment Johan Hovold
2021-03-19 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).