[PATCH] thermal: core: Fix memory leak in the error path

* [PATCH] thermal: core: Fix memory leak in the error path
       [not found] <20210317142215.GA2087@kadam>
@ 2021-03-19 20:22 ` Daniel Lezcano
  0 siblings, 0 replies; only message in thread
From: Daniel Lezcano @ 2021-03-19 20:22 UTC (permalink / raw)
  To: daniel.lezcano
  Cc: kernel test robot, Dan Carpenter, Zhang Rui, Amit Kucheria,
	open list:THERMAL, open list

Fix the following error:

 smatch warnings:
 drivers/thermal/thermal_core.c:1020 __thermal_cooling_device_register() warn: possible memory leak of 'cdev'

by freeing the cdev when exiting the function in the error path.

Fixes: 584837618100 ("thermal/drivers/core: Use a char pointer for the cooling device name")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index c8d4010940ef..3566fd291399 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1017,6 +1017,7 @@ __thermal_cooling_device_register(struct device_node *np,
 out_ida_remove:
 	ida_simple_remove(&thermal_cdev_ida, cdev->id);
 out_kfree_cdev:
+	kfree(cdev);
 	return ERR_PTR(ret);
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread