linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: x86: A typo fix
@ 2021-03-20 19:04 Bhaskar Chowdhury
  2021-03-20 19:12 ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-20 19:04 UTC (permalink / raw)
  To: pbonzini, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
	mingo, bp, x86, hpa, kvm, linux-kernel
  Cc: rdunlap, Bhaskar Chowdhury


s/resued/resumed/

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 arch/x86/include/asm/kvm_host.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 9bc091ecaaeb..eae82551acb1 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
 /*
  * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
  *			userspace I/O) to indicate that the emulation context
- *			should be resued as is, i.e. skip initialization of
+ *			should be resumed as is, i.e. skip initialization of
  *			emulation context, instruction fetch and decode.
  *
  * EMULTYPE_TRAP_UD - Set when emulating an intercepted #UD from hardware.
--
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: x86: A typo fix
  2021-03-20 19:04 [PATCH] KVM: x86: A typo fix Bhaskar Chowdhury
@ 2021-03-20 19:12 ` Randy Dunlap
  2021-03-21 22:54   ` Ingo Molnar
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-03-20 19:12 UTC (permalink / raw)
  To: Bhaskar Chowdhury
  Cc: pbonzini, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
	mingo, bp, x86, hpa, kvm, linux-kernel



On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:

>
> s/resued/resumed/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---
> arch/x86/include/asm/kvm_host.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 9bc091ecaaeb..eae82551acb1 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
> /*
>  * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
>  *			userspace I/O) to indicate that the emulation context
> - *			should be resued as is, i.e. skip initialization of
> + *			should be resumed as is, i.e. skip initialization of
>  *			emulation context, instruction fetch and decode.
>  *
>  * EMULTYPE_TRAP_UD - Set when emulating an intercepted #UD from hardware.
> --
> 2.26.2
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: x86: A typo fix
  2021-03-20 19:12 ` Randy Dunlap
@ 2021-03-21 22:54   ` Ingo Molnar
  2021-03-22  5:29     ` Bhaskar Chowdhury
  0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2021-03-21 22:54 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Bhaskar Chowdhury, pbonzini, seanjc, vkuznets, wanpengli,
	jmattson, joro, tglx, mingo, bp, x86, hpa, kvm, linux-kernel


* Randy Dunlap <rdunlap@bombadil.infradead.org> wrote:

> 
> 
> On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:
> 
> > 
> > s/resued/resumed/
> > 
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> 
> > ---
> > arch/x86/include/asm/kvm_host.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> > index 9bc091ecaaeb..eae82551acb1 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
> > /*
> >  * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
> >  *			userspace I/O) to indicate that the emulation context
> > - *			should be resued as is, i.e. skip initialization of
> > + *			should be resumed as is, i.e. skip initialization of
> >  *			emulation context, instruction fetch and decode.

This is the *wrong* fix, the correct word in this context is 'reused', 
not 'resumed' ...

See how I fixed most arch/x86/ typo fixes in tip:x86/cleanups:

  d9f6e12fb0b7: ("x86: Fix various typos in comments")
  163b099146b8: ("x86: Fix various typos in comments, take #2")

These single file typo fixes are a bad idea for another reason as 
well, as they create a lot of unnecessary churn.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: x86: A typo fix
  2021-03-21 22:54   ` Ingo Molnar
@ 2021-03-22  5:29     ` Bhaskar Chowdhury
  0 siblings, 0 replies; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-22  5:29 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Randy Dunlap, pbonzini, seanjc, vkuznets, wanpengli, jmattson,
	joro, tglx, mingo, bp, x86, hpa, kvm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

On 23:54 Sun 21 Mar 2021, Ingo Molnar wrote:
>
>
>These single file typo fixes are a bad idea for another reason as
>well, as they create a lot of unnecessary churn.
>
Huh! I was expecting it from the moment I started doing it ...finally it arrives.

I am not sure about "so called workflowo of others" ..I am gonna do it in my
way as long as it providing good.

I think this is best way to do it.

~Bhaskar


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-22  5:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-20 19:04 [PATCH] KVM: x86: A typo fix Bhaskar Chowdhury
2021-03-20 19:12 ` Randy Dunlap
2021-03-21 22:54   ` Ingo Molnar
2021-03-22  5:29     ` Bhaskar Chowdhury

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).