* [PATCH] arcc/kernel/process: Few mundane typo fixes
@ 2021-03-22 12:51 Bhaskar Chowdhury
2021-03-22 13:23 ` Christian Brauner
2021-04-07 20:20 ` Vineet Gupta
0 siblings, 2 replies; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-22 12:51 UTC (permalink / raw)
To: vgupta, unixbhaskar, akpm, christian.brauner, keescook, shorne,
walken, viro, jhubbard, daniel.m.jordan, tsbogend, peterx, axboe,
linux-snps-arc, linux-kernel
Cc: rdunlap
s/defintion/definition/
s/succeded/succeeded/
s/commiting/committing/
s/interrutps/interrupts/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
index d838d0d57696..3793876f42d9 100644
--- a/arch/arc/kernel/process.c
+++ b/arch/arc/kernel/process.c
@@ -50,14 +50,14 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
int ret;
/*
- * This is only for old cores lacking LLOCK/SCOND, which by defintion
+ * This is only for old cores lacking LLOCK/SCOND, which by definition
* can't possibly be SMP. Thus doesn't need to be SMP safe.
* And this also helps reduce the overhead for serializing in
* the UP case
*/
WARN_ON_ONCE(IS_ENABLED(CONFIG_SMP));
- /* Z indicates to userspace if operation succeded */
+ /* Z indicates to userspace if operation succeeded */
regs->status32 &= ~STATUS_Z_MASK;
ret = access_ok(uaddr, sizeof(*uaddr));
@@ -107,7 +107,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
void arch_cpu_idle(void)
{
- /* Re-enable interrupts <= default irq priority before commiting SLEEP */
+ /* Re-enable interrupts <= default irq priority before committing SLEEP */
const unsigned int arg = 0x10 | ARCV2_IRQ_DEF_PRIO;
__asm__ __volatile__(
@@ -120,7 +120,7 @@ void arch_cpu_idle(void)
void arch_cpu_idle(void)
{
- /* sleep, but enable both set E1/E2 (levels of interrutps) before committing */
+ /* sleep, but enable both set E1/E2 (levels of interrupts) before committing */
__asm__ __volatile__("sleep 0x3 \n");
}
--
2.31.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arcc/kernel/process: Few mundane typo fixes
2021-03-22 12:51 [PATCH] arcc/kernel/process: Few mundane typo fixes Bhaskar Chowdhury
@ 2021-03-22 13:23 ` Christian Brauner
2021-03-22 19:51 ` Bhaskar Chowdhury
2021-04-07 20:20 ` Vineet Gupta
1 sibling, 1 reply; 4+ messages in thread
From: Christian Brauner @ 2021-03-22 13:23 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: vgupta, akpm, keescook, shorne, walken, viro, jhubbard,
daniel.m.jordan, tsbogend, peterx, axboe, linux-snps-arc,
linux-kernel, rdunlap
On Mon, Mar 22, 2021 at 06:21:55PM +0530, Bhaskar Chowdhury wrote:
> s/defintion/definition/
> s/succeded/succeeded/
> s/commiting/committing/
> s/interrutps/interrupts/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
Since you aim to be mirroring the path arc/kernel/process there's a typo
in the patch subject :)
s/arcc/arc/
otherwise
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arcc/kernel/process: Few mundane typo fixes
2021-03-22 13:23 ` Christian Brauner
@ 2021-03-22 19:51 ` Bhaskar Chowdhury
0 siblings, 0 replies; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-22 19:51 UTC (permalink / raw)
To: Christian Brauner
Cc: vgupta, akpm, keescook, shorne, walken, viro, jhubbard,
daniel.m.jordan, tsbogend, peterx, axboe, linux-snps-arc,
linux-kernel, rdunlap
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On 14:23 Mon 22 Mar 2021, Christian Brauner wrote:
>On Mon, Mar 22, 2021 at 06:21:55PM +0530, Bhaskar Chowdhury wrote:
>> s/defintion/definition/
>> s/succeded/succeeded/
>> s/commiting/committing/
>> s/interrutps/interrupts/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>
>Since you aim to be mirroring the path arc/kernel/process there's a typo
>in the patch subject :)
>s/arcc/arc/
>
Thanks, will be careful in the future.
>otherwise
>
>Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arcc/kernel/process: Few mundane typo fixes
2021-03-22 12:51 [PATCH] arcc/kernel/process: Few mundane typo fixes Bhaskar Chowdhury
2021-03-22 13:23 ` Christian Brauner
@ 2021-04-07 20:20 ` Vineet Gupta
1 sibling, 0 replies; 4+ messages in thread
From: Vineet Gupta @ 2021-04-07 20:20 UTC (permalink / raw)
To: Bhaskar Chowdhury, akpm, christian.brauner, keescook, shorne,
walken, viro, jhubbard, daniel.m.jordan, tsbogend, peterx, axboe,
linux-snps-arc, linux-kernel
Cc: rdunlap
On 3/22/21 5:51 AM, Bhaskar Chowdhury wrote:
> s/defintion/definition/
> s/succeded/succeeded/
> s/commiting/committing/
> s/interrutps/interrupts/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
I've squashed all your 3 patches into one (no reason to break them out)
and queued for 5.13.
Thx,
-Vineet
> ---
> diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
> index d838d0d57696..3793876f42d9 100644
> --- a/arch/arc/kernel/process.c
> +++ b/arch/arc/kernel/process.c
> @@ -50,14 +50,14 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
> int ret;
>
> /*
> - * This is only for old cores lacking LLOCK/SCOND, which by defintion
> + * This is only for old cores lacking LLOCK/SCOND, which by definition
> * can't possibly be SMP. Thus doesn't need to be SMP safe.
> * And this also helps reduce the overhead for serializing in
> * the UP case
> */
> WARN_ON_ONCE(IS_ENABLED(CONFIG_SMP));
>
> - /* Z indicates to userspace if operation succeded */
> + /* Z indicates to userspace if operation succeeded */
> regs->status32 &= ~STATUS_Z_MASK;
>
> ret = access_ok(uaddr, sizeof(*uaddr));
> @@ -107,7 +107,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
>
> void arch_cpu_idle(void)
> {
> - /* Re-enable interrupts <= default irq priority before commiting SLEEP */
> + /* Re-enable interrupts <= default irq priority before committing SLEEP */
> const unsigned int arg = 0x10 | ARCV2_IRQ_DEF_PRIO;
>
> __asm__ __volatile__(
> @@ -120,7 +120,7 @@ void arch_cpu_idle(void)
>
> void arch_cpu_idle(void)
> {
> - /* sleep, but enable both set E1/E2 (levels of interrutps) before committing */
> + /* sleep, but enable both set E1/E2 (levels of interrupts) before committing */
> __asm__ __volatile__("sleep 0x3 \n");
> }
>
> --
> 2.31.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-07 20:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 12:51 [PATCH] arcc/kernel/process: Few mundane typo fixes Bhaskar Chowdhury
2021-03-22 13:23 ` Christian Brauner
2021-03-22 19:51 ` Bhaskar Chowdhury
2021-04-07 20:20 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).