* [PATCH net-next] iwlwifi: fix old-style-declaration warning
@ 2021-03-22 21:51 Arnd Bergmann
2021-03-23 8:04 ` Coelho, Luciano
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-03-22 21:51 UTC (permalink / raw)
To: netdev, Luca Coelho, Kalle Valo, David S. Miller, Jakub Kicinski,
Gregory Greenman
Cc: Arnd Bergmann, linux-wireless, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The correct order is 'static const', not 'const static', as seen from
make W=1:
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 873919048143..4d5a99cbcc9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -11,7 +11,7 @@
* DDR needs frequency in units of 16.666MHz, so provide FW with the
* frequency values in the adjusted format.
*/
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
/* LPDDR4 */
/* frequency 3733MHz */
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] iwlwifi: fix old-style-declaration warning
2021-03-22 21:51 [PATCH net-next] iwlwifi: fix old-style-declaration warning Arnd Bergmann
@ 2021-03-23 8:04 ` Coelho, Luciano
0 siblings, 0 replies; 2+ messages in thread
From: Coelho, Luciano @ 2021-03-23 8:04 UTC (permalink / raw)
To: Greenman, Gregory, kuba, arnd, netdev, kvalo, davem
Cc: linux-wireless, linux-kernel, arnd
On Mon, 2021-03-22 at 22:51 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The correct order is 'static const', not 'const static', as seen from
> make W=1:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
>
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks, Arnd! But I just applied the patch Wei Yongjun submitted, so
we'll go with that one.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 21:51 [PATCH net-next] iwlwifi: fix old-style-declaration warning Arnd Bergmann
2021-03-23 8:04 ` Coelho, Luciano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).