* Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword
2021-03-23 7:54 [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword Zou Wei
@ 2021-03-23 7:19 ` Leo Yan
2021-03-23 9:47 ` Suzuki K Poulose
1 sibling, 0 replies; 3+ messages in thread
From: Leo Yan @ 2021-03-23 7:19 UTC (permalink / raw)
To: Zou Wei
Cc: mathieu.poirier, suzuki.poulose, mike.leach, alexander.shishkin,
coresight, linux-arm-kernel, linux-kernel
On Tue, Mar 23, 2021 at 07:54:52AM +0000, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 0f603b4094f2..bdbb77334329 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
> return sprintf(page, "config:%d\n", pid_fmt);
> }
>
> -struct device_attribute format_attr_contextid =
> +static struct device_attribute format_attr_contextid =
> __ATTR(contextid, 0444, format_attr_contextid_show, NULL);
>
> static struct attribute *etm_config_formats_attr[] = {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword
@ 2021-03-23 7:54 Zou Wei
2021-03-23 7:19 ` Leo Yan
2021-03-23 9:47 ` Suzuki K Poulose
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2021-03-23 7:54 UTC (permalink / raw)
To: mathieu.poirier, suzuki.poulose, mike.leach, leo.yan,
alexander.shishkin, coresight
Cc: linux-arm-kernel, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
'format_attr_contextid' was not declared. Should it be static?
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 0f603b4094f2..bdbb77334329 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
return sprintf(page, "config:%d\n", pid_fmt);
}
-struct device_attribute format_attr_contextid =
+static struct device_attribute format_attr_contextid =
__ATTR(contextid, 0444, format_attr_contextid_show, NULL);
static struct attribute *etm_config_formats_attr[] = {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword
2021-03-23 7:54 [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword Zou Wei
2021-03-23 7:19 ` Leo Yan
@ 2021-03-23 9:47 ` Suzuki K Poulose
1 sibling, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2021-03-23 9:47 UTC (permalink / raw)
To: Zou Wei, mathieu.poirier, mike.leach, leo.yan,
alexander.shishkin, coresight
Cc: linux-arm-kernel, linux-kernel
On 23/03/2021 07:54, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
>
A fix is already queued in coresight/next.
Thanks
Suzuki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-23 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 7:54 [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword Zou Wei
2021-03-23 7:19 ` Leo Yan
2021-03-23 9:47 ` Suzuki K Poulose
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).