* [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword
@ 2021-03-23 7:48 Zou Wei
2021-03-24 23:20 ` [Nouveau] " Ben Skeggs
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-03-23 7:48 UTC (permalink / raw)
To: bskeggs, airlied, daniel; +Cc: dri-devel, nouveau, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol 'nvkm_uclient_sclass' was not declared. Should it be static?
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/client.c b/drivers/gpu/drm/nouveau/nvkm/core/client.c
index ac671202919e..0c8c55c73b12 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/client.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/client.c
@@ -60,7 +60,7 @@ nvkm_uclient_new(const struct nvkm_oclass *oclass, void *argv, u32 argc,
return 0;
}
-const struct nvkm_sclass
+static const struct nvkm_sclass
nvkm_uclient_sclass = {
.oclass = NVIF_CLASS_CLIENT,
.minver = 0,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword
2021-03-23 7:48 [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword Zou Wei
@ 2021-03-24 23:20 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2021-03-24 23:20 UTC (permalink / raw)
To: Zou Wei
Cc: Ben Skeggs, Dave Airlie, Daniel Vetter, ML nouveau, LKML, ML dri-devel
On Tue, 23 Mar 2021 at 17:03, Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol 'nvkm_uclient_sclass' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Applied, thanks.
> ---
> drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/client.c b/drivers/gpu/drm/nouveau/nvkm/core/client.c
> index ac671202919e..0c8c55c73b12 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/client.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/client.c
> @@ -60,7 +60,7 @@ nvkm_uclient_new(const struct nvkm_oclass *oclass, void *argv, u32 argc,
> return 0;
> }
>
> -const struct nvkm_sclass
> +static const struct nvkm_sclass
> nvkm_uclient_sclass = {
> .oclass = NVIF_CLASS_CLIENT,
> .minver = 0,
> --
> 2.17.1
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 7:48 [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword Zou Wei
2021-03-24 23:20 ` [Nouveau] " Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).