* [PATCH v2] arm64: dts: imx8mq-kontron-pitx-imx8m: pass phy reset delays
@ 2021-03-23 14:00 Heiko Thiery
2021-03-29 1:51 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Thiery @ 2021-03-23 14:00 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-kernel
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Michael Walle, Heiko Thiery
The TI DP83867 PHY datasheet says:
T1: Post RESET stabilization time == 195us
T3: Hardware configuration pins transition to output drivers == 64us
T4: RESET pulse width == 1us
So with a little overhead set 'reset-assert-us' to 10us (T4) and
'reset-deassert-us' to 280us (T1+T3).
Without these reset delays the board will hang during startup when
bootargs has ip=dhcp set.
Fixes: 1dc7f3d79a1a ("arm64: dts: fsl: add support for Kontron pitx-imx8m board")
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
v2:
- add desciption what issue will be fixed
- add Fixes tag
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
index 91a9ceb10305..f593e4ff62e1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
@@ -90,6 +90,8 @@ ethphy0: ethernet-phy@0 {
ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_75_NS>;
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10>;
+ reset-deassert-us = <280>;
};
};
};
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: imx8mq-kontron-pitx-imx8m: pass phy reset delays
2021-03-23 14:00 [PATCH v2] arm64: dts: imx8mq-kontron-pitx-imx8m: pass phy reset delays Heiko Thiery
@ 2021-03-29 1:51 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-03-29 1:51 UTC (permalink / raw)
To: Heiko Thiery
Cc: devicetree, linux-arm-kernel, linux-kernel, Rob Herring,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Michael Walle
On Tue, Mar 23, 2021 at 03:00:21PM +0100, Heiko Thiery wrote:
> The TI DP83867 PHY datasheet says:
> T1: Post RESET stabilization time == 195us
> T3: Hardware configuration pins transition to output drivers == 64us
> T4: RESET pulse width == 1us
>
> So with a little overhead set 'reset-assert-us' to 10us (T4) and
> 'reset-deassert-us' to 280us (T1+T3).
>
> Without these reset delays the board will hang during startup when
> bootargs has ip=dhcp set.
>
> Fixes: 1dc7f3d79a1a ("arm64: dts: fsl: add support for Kontron pitx-imx8m board")
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
> - add desciption what issue will be fixed
> - add Fixes tag
My branch is not a stable one, so I just squashed it into the original
commit.
Shawn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 1:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 14:00 [PATCH v2] arm64: dts: imx8mq-kontron-pitx-imx8m: pass phy reset delays Heiko Thiery
2021-03-29 1:51 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).