* [PATCH][next] media: dvb-frontends: Remove redundant error check on variable ret
@ 2021-03-23 14:00 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2021-03-23 14:00 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sean Young, Gustavo A . R . Silva,
Daniel W . S . Almeida, Brad Love, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
An earlier commit removed a call to lgdt3306a_spectral_inversion and
omitted to remove the error return check. The check on ret is now
redundant and can be removed.
Addresses-Coverity: ("Logically dead code")
Fixes: d4a3fa6652e3 ("media: dvb-frontends: lgdt3306a.c: remove dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/dvb-frontends/lgdt3306a.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
index 22d484487695..136b76cb4807 100644
--- a/drivers/media/dvb-frontends/lgdt3306a.c
+++ b/drivers/media/dvb-frontends/lgdt3306a.c
@@ -1017,9 +1017,6 @@ static int lgdt3306a_set_parameters(struct dvb_frontend *fe)
/* spectral_inversion defaults already set for VSB and QAM */
- if (lg_chkerr(ret))
- goto fail;
-
ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode);
if (lg_chkerr(ret))
goto fail;
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-23 14:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 14:00 [PATCH][next] media: dvb-frontends: Remove redundant error check on variable ret Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).