linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes
@ 2021-03-23 20:00 Rob Herring
  2021-03-24 11:18 ` Sameer Pujar
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2021-03-23 20:00 UTC (permalink / raw)
  To: Mark Brown
  Cc: devicetree, linux-kernel, Liam Girdwood, Thierry Reding,
	Jonathan Hunter, Sameer Pujar, alsa-devel, linux-tegra

The nvidia,tegra210-ahub binding is missing schema for child nodes. This
results in warnings if 'additionalProperties: false' is set (or when the
tools implement 'unevaluatedProperties' support). Add the child nodes
and reference their schema if one exists.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Sameer Pujar <spujar@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
This patch ideally should be applied before this series[1].

[1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/

 .../bindings/sound/nvidia,tegra210-ahub.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
index e568d6c7dddd..d7a5eb77ed4f 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
@@ -69,6 +69,18 @@ properties:
         $ref: audio-graph-port.yaml#
         unevaluatedProperties: false
 
+patternProperties:
+  '^i2s@[0-9a-f]+$':
+    type: object
+
+  '^dmic@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-dmic.yaml#
+
+  '^admaif@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-admaif.yaml#
+
 required:
   - compatible
   - reg
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes
  2021-03-23 20:00 [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
@ 2021-03-24 11:18 ` Sameer Pujar
  0 siblings, 0 replies; 2+ messages in thread
From: Sameer Pujar @ 2021-03-24 11:18 UTC (permalink / raw)
  To: Rob Herring, Mark Brown
  Cc: devicetree, linux-kernel, Liam Girdwood, Thierry Reding,
	Jonathan Hunter, alsa-devel, linux-tegra



On 3/24/2021 1:30 AM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Sameer Pujar <spujar@nvidia.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> This patch ideally should be applied before this series[1].
>
> [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/
>
>   .../bindings/sound/nvidia,tegra210-ahub.yaml         | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> index e568d6c7dddd..d7a5eb77ed4f 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> @@ -69,6 +69,18 @@ properties:
>           $ref: audio-graph-port.yaml#
>           unevaluatedProperties: false
>
> +patternProperties:
> +  '^i2s@[0-9a-f]+$':
> +    type: object
> +
> +  '^dmic@[0-9a-f]+$':
> +    type: object
> +    $ref: nvidia,tegra210-dmic.yaml#
> +
> +  '^admaif@[0-9a-f]+$':
> +    type: object
> +    $ref: nvidia,tegra210-admaif.yaml#
> +

There is "dspk@xxx" child node as well for ahub, though schema example 
does not show this. I am seeing error because of this during 
"dtbs_check". Wondering if we can add following with this patch?

+  '^dspk@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra186-dspk.yaml#


>   required:
>     - compatible
>     - reg
> --
> 2.27.0
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-24 11:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 20:00 [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes Rob Herring
2021-03-24 11:18 ` Sameer Pujar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).