linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints
Date: Wed, 24 Mar 2021 10:53:13 -0400	[thread overview]
Message-ID: <20210324105313.4ff3ad07@gandalf.local.home> (raw)
In-Reply-To: <20210324144853.GA5718@roeck-us.net>

On Wed, 24 Mar 2021 07:48:53 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

> On Wed, Mar 24, 2021 at 07:34:07AM -0700, Guenter Roeck wrote:
> > On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote:  
> > > Add tracepoints to retrieve information about the invoke_fn. This would
> > > help to measure how many invoke_fn are triggered and how long it takes
> > > to complete one invoke_fn call.
> > > 
> > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>  
> > 
> > arm64:defconfig:
> > 
> > make-arm64 -j drivers/tee/optee/call.o
> >   CALL    scripts/atomic/check-atomics.sh
> >   CALL    scripts/checksyscalls.sh
> >   CC      drivers/tee/optee/call.o
> > In file included from drivers/tee/optee/optee_trace.h:67,
> >                  from drivers/tee/optee/call.c:18:
> > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> >    95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> >       |                                          ^
> > compilation terminated.
> >   
> 
> The problem also affects arm:imx_v6_v7_defconfig.
> 

I think it affects everything. The problem is that the
drivers/tee/optee/Makefile needs to be updated with:

CFLAGS_call.o := -I$(src)

otherwise the compiler wont know how to find the path to optee_tree.h.

This is described in:

   samples/trace_events/Makefile

-- Steve

  reply	other threads:[~2021-03-24 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  6:44 [PATCH] tee: optee: add invoke_fn tracepoints Jisheng Zhang
2021-02-10 14:37 ` Steven Rostedt
2021-02-23  7:59 ` Jens Wiklander
2021-02-23 10:40   ` Jisheng Zhang
2021-02-23 13:11     ` Jens Wiklander
2021-02-23 14:19       ` Steven Rostedt
2021-02-24  8:10         ` Jens Wiklander
2021-03-24 14:34 ` Guenter Roeck
2021-03-24 14:48   ` Guenter Roeck
2021-03-24 14:53     ` Steven Rostedt [this message]
2021-03-25  3:50       ` Jisheng Zhang
2021-03-25  7:49         ` Jens Wiklander
  -- strict thread matches above, loose matches on Subject: below --
2021-02-09 11:02 Jisheng Zhang
2021-02-09 15:58 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324105313.4ff3ad07@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=Jisheng.Zhang@synaptics.com \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=op-tee@lists.trustedfirmware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).