From: Jens Wiklander <jens.wiklander@linaro.org>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Guenter Roeck <linux@roeck-us.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints
Date: Thu, 25 Mar 2021 07:49:19 +0000 [thread overview]
Message-ID: <CAHUa44GC9Co3v6RqqwpnAVRnGzWZyPnr=7Ww8C5_deoBpruPTg@mail.gmail.com> (raw)
In-Reply-To: <20210325115043.6c00a33e@xhacker.debian>
On Thu, Mar 25, 2021 at 3:50 AM Jisheng Zhang
<Jisheng.Zhang@synaptics.com> wrote:
>
> On Wed, 24 Mar 2021 10:53:13 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> >
> > On Wed, 24 Mar 2021 07:48:53 -0700
> > Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > > On Wed, Mar 24, 2021 at 07:34:07AM -0700, Guenter Roeck wrote:
> > > > On Wed, Feb 10, 2021 at 02:44:09PM +0800, Jisheng Zhang wrote:
> > > > > Add tracepoints to retrieve information about the invoke_fn. This would
> > > > > help to measure how many invoke_fn are triggered and how long it takes
> > > > > to complete one invoke_fn call.
> > > > >
> > > > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> > > >
> > > > arm64:defconfig:
> > > >
> > > > make-arm64 -j drivers/tee/optee/call.o
> > > > CALL scripts/atomic/check-atomics.sh
> > > > CALL scripts/checksyscalls.sh
> > > > CC drivers/tee/optee/call.o
> > > > In file included from drivers/tee/optee/optee_trace.h:67,
> > > > from drivers/tee/optee/call.c:18:
> > > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> > > > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > > > | ^
> > > > compilation terminated.
>
> Interesting, I always build linux kernel with "O=", didn't see such build error
> and IIRC, we didn't receive any lkp robot build error report.
>
> My steps are:
>
> mkdir /tmp/test
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=/tmp/test defconfig
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=/tmp/test drivers/tee/optee/
>
> Today, I tried to build the linux kernel w/o "O=...", I reproduced this error!
> This is the first time I saw "O=" make a different behavior.
I'm also compiling with O=... and couldn't understand what was going
on. Thanks for saving me from digging any deeper.
>
> I'll send out a patch to fix it.
Thanks,
Jens
next prev parent reply other threads:[~2021-03-25 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 6:44 [PATCH] tee: optee: add invoke_fn tracepoints Jisheng Zhang
2021-02-10 14:37 ` Steven Rostedt
2021-02-23 7:59 ` Jens Wiklander
2021-02-23 10:40 ` Jisheng Zhang
2021-02-23 13:11 ` Jens Wiklander
2021-02-23 14:19 ` Steven Rostedt
2021-02-24 8:10 ` Jens Wiklander
2021-03-24 14:34 ` Guenter Roeck
2021-03-24 14:48 ` Guenter Roeck
2021-03-24 14:53 ` Steven Rostedt
2021-03-25 3:50 ` Jisheng Zhang
2021-03-25 7:49 ` Jens Wiklander [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 11:02 Jisheng Zhang
2021-02-09 15:58 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHUa44GC9Co3v6RqqwpnAVRnGzWZyPnr=7Ww8C5_deoBpruPTg@mail.gmail.com' \
--to=jens.wiklander@linaro.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=op-tee@lists.trustedfirmware.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).