linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM
@ 2021-03-24 14:17 Andy Shevchenko
  2021-03-25  4:19 ` Viresh Kumar
  2021-04-12  9:24 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-03-24 14:17 UTC (permalink / raw)
  To: Andy Shevchenko, dmaengine, linux-kernel
  Cc: Viresh Kumar, Vinod Koul, kernel test robot

Some architectures do not provide devm_*() APIs. Hence make the driver
dependent on HAVE_IOMEM.

Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: used proper option (Serge)
 drivers/dma/dw/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig
index e5162690de8f..db25f9b7778c 100644
--- a/drivers/dma/dw/Kconfig
+++ b/drivers/dma/dw/Kconfig
@@ -10,6 +10,7 @@ config DW_DMAC_CORE
 
 config DW_DMAC
 	tristate "Synopsys DesignWare AHB DMA platform driver"
+	depends on HAS_IOMEM
 	select DW_DMAC_CORE
 	help
 	  Support the Synopsys DesignWare AHB DMA controller. This
@@ -18,6 +19,7 @@ config DW_DMAC
 config DW_DMAC_PCI
 	tristate "Synopsys DesignWare AHB DMA PCI driver"
 	depends on PCI
+	depends on HAS_IOMEM
 	select DW_DMAC_CORE
 	help
 	  Support the Synopsys DesignWare AHB DMA controller on the
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM
  2021-03-24 14:17 [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM Andy Shevchenko
@ 2021-03-25  4:19 ` Viresh Kumar
  2021-04-12  9:24 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2021-03-25  4:19 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: dmaengine, linux-kernel, Viresh Kumar, Vinod Koul, kernel test robot

On 24-03-21, 16:17, Andy Shevchenko wrote:
> Some architectures do not provide devm_*() APIs. Hence make the driver
> dependent on HAVE_IOMEM.
> 
> Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: used proper option (Serge)
>  drivers/dma/dw/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig
> index e5162690de8f..db25f9b7778c 100644
> --- a/drivers/dma/dw/Kconfig
> +++ b/drivers/dma/dw/Kconfig
> @@ -10,6 +10,7 @@ config DW_DMAC_CORE
>  
>  config DW_DMAC
>  	tristate "Synopsys DesignWare AHB DMA platform driver"
> +	depends on HAS_IOMEM
>  	select DW_DMAC_CORE
>  	help
>  	  Support the Synopsys DesignWare AHB DMA controller. This
> @@ -18,6 +19,7 @@ config DW_DMAC
>  config DW_DMAC_PCI
>  	tristate "Synopsys DesignWare AHB DMA PCI driver"
>  	depends on PCI
> +	depends on HAS_IOMEM
>  	select DW_DMAC_CORE
>  	help
>  	  Support the Synopsys DesignWare AHB DMA controller on the

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM
  2021-03-24 14:17 [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM Andy Shevchenko
  2021-03-25  4:19 ` Viresh Kumar
@ 2021-04-12  9:24 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-04-12  9:24 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: dmaengine, linux-kernel, Viresh Kumar, kernel test robot

On 24-03-21, 16:17, Andy Shevchenko wrote:
> Some architectures do not provide devm_*() APIs. Hence make the driver
> dependent on HAVE_IOMEM.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-12  9:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 14:17 [PATCH v2 1/1] dmaengine: dw: Make it dependent to HAS_IOMEM Andy Shevchenko
2021-03-25  4:19 ` Viresh Kumar
2021-04-12  9:24 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).