* [PATCH] drivers: gpu: drm: Remove duplicate declaration
@ 2021-03-25 4:50 Wan Jiabing
2021-03-25 9:04 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-03-25 4:50 UTC (permalink / raw)
To: Tomi Valkeinen, David Airlie, Daniel Vetter, Sebastian Reichel,
Laurent Pinchart, Jyri Sarha, dri-devel, linux-kernel
Cc: kael_w, Wan Jiabing
struct dss_device has been declared at 51st line.
Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index a40abeafd2e9..2658aadee09a 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -52,7 +52,6 @@ struct dss_device;
struct omap_drm_private;
struct omap_dss_device;
struct dispc_device;
-struct dss_device;
struct dss_lcd_mgr_config;
struct snd_aes_iec958;
struct snd_cea_861_aud_if;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: gpu: drm: Remove duplicate declaration
2021-03-25 4:50 [PATCH] drivers: gpu: drm: Remove duplicate declaration Wan Jiabing
@ 2021-03-25 9:04 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2021-03-25 9:04 UTC (permalink / raw)
To: Wan Jiabing
Cc: Tomi Valkeinen, David Airlie, Daniel Vetter, Sebastian Reichel,
Jyri Sarha, dri-devel, linux-kernel, kael_w
Hi Wan,
Thank you for the patch.
On Thu, Mar 25, 2021 at 12:50:19PM +0800, Wan Jiabing wrote:
> struct dss_device has been declared at 51st line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index a40abeafd2e9..2658aadee09a 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -52,7 +52,6 @@ struct dss_device;
> struct omap_drm_private;
> struct omap_dss_device;
> struct dispc_device;
> -struct dss_device;
> struct dss_lcd_mgr_config;
> struct snd_aes_iec958;
> struct snd_cea_861_aud_if;
While at it, could you sort these forward declarations alphabetically,
so that duplicates are easier to see ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 4:50 [PATCH] drivers: gpu: drm: Remove duplicate declaration Wan Jiabing
2021-03-25 9:04 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).