* [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk
@ 2021-03-25 19:28 Al Cooper
2021-03-25 22:34 ` Florian Fainelli
2021-03-30 10:44 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Al Cooper @ 2021-03-25 19:28 UTC (permalink / raw)
To: linux-kernel
Cc: Al Cooper, Adrian Hunter, bcm-kernel-feedback-list,
Florian Fainelli, Krzysztof Kozlowski, linux-arm-kernel,
linux-mmc, Ulf Hansson
Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the
latest chips have this fixed and earlier chips have other
CQE problems that prevent the feature from being enabled.
Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
drivers/mmc/host/sdhci-brcmstb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index f9780c65ebe9..f24623aac2db 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -199,7 +199,6 @@ static int sdhci_brcmstb_add_host(struct sdhci_host *host,
if (dma64) {
dev_dbg(mmc_dev(host->mmc), "Using 64 bit DMA\n");
cq_host->caps |= CQHCI_TASK_DESC_SZ_128;
- cq_host->quirks |= CQHCI_QUIRK_SHORT_TXFR_DESC_SZ;
}
ret = cqhci_init(cq_host, host->mmc, dma64);
base-commit: e138138003eb3b3d06cc91cf2e8c5dec77e2a31e
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk
2021-03-25 19:28 [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk Al Cooper
@ 2021-03-25 22:34 ` Florian Fainelli
2021-03-30 10:44 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-03-25 22:34 UTC (permalink / raw)
To: Al Cooper, linux-kernel
Cc: Adrian Hunter, bcm-kernel-feedback-list, Florian Fainelli,
Krzysztof Kozlowski, linux-arm-kernel, linux-mmc, Ulf Hansson
On 3/25/2021 12:28 PM, Al Cooper wrote:
> Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the
> latest chips have this fixed and earlier chips have other
> CQE problems that prevent the feature from being enabled.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk
2021-03-25 19:28 [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk Al Cooper
2021-03-25 22:34 ` Florian Fainelli
@ 2021-03-30 10:44 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2021-03-30 10:44 UTC (permalink / raw)
To: Al Cooper
Cc: Linux Kernel Mailing List, Adrian Hunter, BCM Kernel Feedback,
Florian Fainelli, Krzysztof Kozlowski, Linux ARM, linux-mmc
On Thu, 25 Mar 2021 at 20:28, Al Cooper <alcooperx@gmail.com> wrote:
>
> Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the
> latest chips have this fixed and earlier chips have other
> CQE problems that prevent the feature from being enabled.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-brcmstb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index f9780c65ebe9..f24623aac2db 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -199,7 +199,6 @@ static int sdhci_brcmstb_add_host(struct sdhci_host *host,
> if (dma64) {
> dev_dbg(mmc_dev(host->mmc), "Using 64 bit DMA\n");
> cq_host->caps |= CQHCI_TASK_DESC_SZ_128;
> - cq_host->quirks |= CQHCI_QUIRK_SHORT_TXFR_DESC_SZ;
> }
>
> ret = cqhci_init(cq_host, host->mmc, dma64);
>
> base-commit: e138138003eb3b3d06cc91cf2e8c5dec77e2a31e
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-30 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 19:28 [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk Al Cooper
2021-03-25 22:34 ` Florian Fainelli
2021-03-30 10:44 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).