linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/Microchip (AT91) SoC support)
Subject: [PATCH 02/17] ASoC: atmel: fix shadowed variable
Date: Fri, 26 Mar 2021 16:59:12 -0500	[thread overview]
Message-ID: <20210326215927.936377-3-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>

Fix cppcheck warning:

sound/soc/atmel/atmel-classd.c:51:14: style: Local variable 'pwm_type'
shadows outer variable [shadowVariable]
 const char *pwm_type;
             ^
sound/soc/atmel/atmel-classd.c:226:27: note: Shadowed declaration
static const char * const pwm_type[] = {
                          ^
sound/soc/atmel/atmel-classd.c:51:14: note: Shadow variable
 const char *pwm_type;
             ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/atmel/atmel-classd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
index b1a28a9382fb..6023369e0f1a 100644
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -48,7 +48,7 @@ static struct atmel_classd_pdata *atmel_classd_dt_init(struct device *dev)
 {
 	struct device_node *np = dev->of_node;
 	struct atmel_classd_pdata *pdata;
-	const char *pwm_type;
+	const char *pwm_type_s;
 	int ret;
 
 	if (!np) {
@@ -60,8 +60,8 @@ static struct atmel_classd_pdata *atmel_classd_dt_init(struct device *dev)
 	if (!pdata)
 		return ERR_PTR(-ENOMEM);
 
-	ret = of_property_read_string(np, "atmel,pwm-type", &pwm_type);
-	if ((ret == 0) && (strcmp(pwm_type, "diff") == 0))
+	ret = of_property_read_string(np, "atmel,pwm-type", &pwm_type_s);
+	if ((ret == 0) && (strcmp(pwm_type_s, "diff") == 0))
 		pdata->pwm_type = CLASSD_MR_PWMTYP_DIFF;
 	else
 		pdata->pwm_type = CLASSD_MR_PWMTYP_SINGLE;
-- 
2.25.1


  parent reply	other threads:[~2021-03-26 22:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 21:59 [PATCH 00/17] ASoC: remove cppcheck warnings for multiple SOCs Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 01/17] ASoC: amd: renoir: acp3x-pdm-dma: remove unnecessary assignments Pierre-Louis Bossart
2021-03-26 21:59 ` Pierre-Louis Bossart [this message]
2021-03-29  7:38   ` [PATCH 02/17] ASoC: atmel: fix shadowed variable Codrin.Ciubotariu
2021-03-26 21:59 ` [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization Pierre-Louis Bossart
2021-03-29  7:32   ` Codrin.Ciubotariu
2021-03-26 21:59 ` [PATCH 04/17] ASoC: bcm: cygnus_ssp: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 05/17] ASoC: meson: axg-tdmin: remove useless assignment Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 06/17] ASoC: meson: axg-tdmout: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 07/17] ASoC: pxa: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check Pierre-Louis Bossart
2021-03-29  8:01   ` Arnaud POULIQUEN
2021-03-26 21:59 ` [PATCH 09/17] ASoC: sti: uniperif: align function prototypes Pierre-Louis Bossart
2021-03-29  8:00   ` Arnaud POULIQUEN
2021-03-26 21:59 ` [PATCH 10/17] ASoC: stm: stm32_adfsdm: fix snprintf format string Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 11/17] ASoC: sunxi: sun8i-codec: clarify expression Pierre-Louis Bossart
2021-03-29  8:12   ` Maxime Ripard
2021-03-26 21:59 ` [PATCH 12/17] ASoC: tegra: tegra20_das: " Pierre-Louis Bossart
2021-03-29  7:14   ` Thierry Reding
2021-03-26 21:59 ` [PATCH 13/17] ASoC: tegra: tegra20_das: align function prototypes Pierre-Louis Bossart
2021-03-29  7:14   ` Thierry Reding
2021-03-26 21:59 ` [PATCH 14/17] ASoC: ti: omap-abe-twl6040: remove useless assignment Pierre-Louis Bossart
2021-03-29  5:52   ` Péter Ujfalusi
2021-03-26 21:59 ` [PATCH 15/17] ASoC: ti: omap-mcsp: remove duplicate test Pierre-Louis Bossart
2021-03-29  5:56   ` Péter Ujfalusi
2021-03-26 21:59 ` [PATCH 16/17] ASoC: ux500: mop500: rename shadowing variable Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 17/17] ASoC: ux500: mop500: align function prototype Pierre-Louis Bossart
2021-04-01 10:16 ` [PATCH 00/17] ASoC: remove cppcheck warnings for multiple SOCs Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326215927.936377-3-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).