From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: RE: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check
Date: Mon, 29 Mar 2021 08:01:21 +0000 [thread overview]
Message-ID: <DB9PR10MB4746812285B4E6A66546C12FF17E9@DB9PR10MB4746.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210326215927.936377-9-pierre-louis.bossart@linux.intel.com>
> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Sent: vendredi 26 mars 2021 22:59
> To: alsa-devel@alsa-project.org
> Cc: tiwai@suse.de; broonie@kernel.org; linux-kernel@vger.kernel.org; Pierre-
> Louis Bossart <pierre-louis.bossart@linux.intel.com>; Arnaud POULIQUEN
> <arnaud.pouliquen@st.com>; Liam Girdwood <lgirdwood@gmail.com>;
> Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>
> Subject: [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check
>
> cppcheck warning:
>
> sound/soc/sti/sti_uniperif.c:490:6: style: Variable 'ret' is reassigned a value
> before the old one has been used. [redundantAssignment] ret =
> devm_snd_soc_register_component(&pdev->dev,
> ^
> sound/soc/sti/sti_uniperif.c:486:6: note: ret is assigned ret =
> sti_uniperiph_cpu_dai_of(node, priv);
> ^
> sound/soc/sti/sti_uniperif.c:490:6: note: ret is overwritten ret =
> devm_snd_soc_register_component(&pdev->dev,
> ^
>
> sti_uniperiph_cpu_dai_of() can return -EINVAL which seems like a good-enough
> reason to bail.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks
Arnaud
> ---
> sound/soc/sti/sti_uniperif.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c index
> 7b9169f04d6e..67315d9b352d 100644
> --- a/sound/soc/sti/sti_uniperif.c
> +++ b/sound/soc/sti/sti_uniperif.c
> @@ -484,6 +484,8 @@ static int sti_uniperiph_probe(struct platform_device
> *pdev)
> priv->pdev = pdev;
>
> ret = sti_uniperiph_cpu_dai_of(node, priv);
> + if (ret < 0)
> + return ret;
>
> dev_set_drvdata(&pdev->dev, priv);
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-03-29 8:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 21:59 [PATCH 00/17] ASoC: remove cppcheck warnings for multiple SOCs Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 01/17] ASoC: amd: renoir: acp3x-pdm-dma: remove unnecessary assignments Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 02/17] ASoC: atmel: fix shadowed variable Pierre-Louis Bossart
2021-03-29 7:38 ` Codrin.Ciubotariu
2021-03-26 21:59 ` [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization Pierre-Louis Bossart
2021-03-29 7:32 ` Codrin.Ciubotariu
2021-03-26 21:59 ` [PATCH 04/17] ASoC: bcm: cygnus_ssp: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 05/17] ASoC: meson: axg-tdmin: remove useless assignment Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 06/17] ASoC: meson: axg-tdmout: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 07/17] ASoC: pxa: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 08/17] ASoC: sti: sti_uniperif: add missing error check Pierre-Louis Bossart
2021-03-29 8:01 ` Arnaud POULIQUEN [this message]
2021-03-26 21:59 ` [PATCH 09/17] ASoC: sti: uniperif: align function prototypes Pierre-Louis Bossart
2021-03-29 8:00 ` Arnaud POULIQUEN
2021-03-26 21:59 ` [PATCH 10/17] ASoC: stm: stm32_adfsdm: fix snprintf format string Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 11/17] ASoC: sunxi: sun8i-codec: clarify expression Pierre-Louis Bossart
2021-03-29 8:12 ` Maxime Ripard
2021-03-26 21:59 ` [PATCH 12/17] ASoC: tegra: tegra20_das: " Pierre-Louis Bossart
2021-03-29 7:14 ` Thierry Reding
2021-03-26 21:59 ` [PATCH 13/17] ASoC: tegra: tegra20_das: align function prototypes Pierre-Louis Bossart
2021-03-29 7:14 ` Thierry Reding
2021-03-26 21:59 ` [PATCH 14/17] ASoC: ti: omap-abe-twl6040: remove useless assignment Pierre-Louis Bossart
2021-03-29 5:52 ` Péter Ujfalusi
2021-03-26 21:59 ` [PATCH 15/17] ASoC: ti: omap-mcsp: remove duplicate test Pierre-Louis Bossart
2021-03-29 5:56 ` Péter Ujfalusi
2021-03-26 21:59 ` [PATCH 16/17] ASoC: ux500: mop500: rename shadowing variable Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 17/17] ASoC: ux500: mop500: align function prototype Pierre-Louis Bossart
2021-04-01 10:16 ` [PATCH 00/17] ASoC: remove cppcheck warnings for multiple SOCs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR10MB4746812285B4E6A66546C12FF17E9@DB9PR10MB4746.EURPRD10.PROD.OUTLOOK.COM \
--to=arnaud.pouliquen@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).