[PATCH 0/2] dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node "snps,dwc3"

[PATCH 0/2] dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node "snps,dwc3"

[Zhen Lei]

File snps,dwc3.yaml describes the schema of Synopsys DesignWare USB3
Controller, it directly or indirectly contains "$ref: usb.yaml". So the
node name of "snps,dwc3" must start with "usb". Otherwise, the following
warning will be displayed:

Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.example.dt.yaml: \
dwc3@38100000: $nodename:0: 'dwc3@38100000' does not match '^usb(@.*)?'
        From schema: Documentation/devicetree/bindings/usb/snps,dwc3.yaml


Zhen Lei (2):
  dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node
    "snps,dwc3"
  arm64: dts: imx8mp: Use the correct name for child node "snps,dwc3"

 Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml | 9 +++------
 arch/arm64/boot/dts/freescale/imx8mp.dtsi                  | 4 ++--
 2 files changed, 5 insertions(+), 8 deletions(-)

-- 
1.8.3

[PATCH 1/2] dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node "snps,dwc3"

[Zhen Lei]

File snps,dwc3.yaml describes the schema of Synopsys DesignWare USB3
Controller, it directly or indirectly contains "$ref: usb.yaml". So the
node name of "snps,dwc3" must start with "usb". Otherwise, the following
warning will be displayed:

Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.example.dt.yaml: \
dwc3@38100000: $nodename:0: 'dwc3@38100000' does not match '^usb(@.*)?'
        From schema: Documentation/devicetree/bindings/usb/snps,dwc3.yaml

In addition, replace "type: object" with "$ref: snps,dwc3.yaml#". Ensure
that all properties of the child node comply with snps,dwc3.yaml.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml
index cb4c6f6d3a33a3f..974032b1fda04fb 100644
--- a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml
@@ -52,11 +52,8 @@ properties:
 # Required child node:
 
 patternProperties:
-  "^dwc3@[0-9a-f]+$":
-    type: object
-    description:
-      A child node must exist to represent the core DWC3 IP block
-      The content of the node is defined in dwc3.txt.
+  "^usb@[0-9a-f]+$":
+    $ref: snps,dwc3.yaml#
 
 required:
   - compatible
@@ -87,7 +84,7 @@ examples:
       dma-ranges = <0x40000000 0x40000000 0xc0000000>;
       ranges;
 
-      dwc3@38100000 {
+      usb@38100000 {
         compatible = "snps,dwc3";
         reg = <0x38100000 0x10000>;
         clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
-- 
1.8.3

Re: [PATCH 1/2] dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node "snps, dwc3"

[Rob Herring]

On Mon, 29 Mar 2021 15:27:13 +0800, Zhen Lei wrote:
> File snps,dwc3.yaml describes the schema of Synopsys DesignWare USB3
> Controller, it directly or indirectly contains "$ref: usb.yaml". So the
> node name of "snps,dwc3" must start with "usb". Otherwise, the following
> warning will be displayed:
> 
> Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.example.dt.yaml: \
> dwc3@38100000: $nodename:0: 'dwc3@38100000' does not match '^usb(@.*)?'
>         From schema: Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> 
> In addition, replace "type: object" with "$ref: snps,dwc3.yaml#". Ensure
> that all properties of the child node comply with snps,dwc3.yaml.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 2/2] arm64: dts: imx8mp: Use the correct name for child node "snps,dwc3"

[Zhen Lei]

After the node name of "snps,dwc3" has been corrected to start with "usb"
in fsl,imx8mp-dwc3.yaml. Its name in dts should be modified accordingly.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index c7523fd4eae9b53..4967d72f41f613f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -828,7 +828,7 @@
 			ranges;
 			status = "disabled";
 
-			usb_dwc3_0: dwc3@38100000 {
+			usb_dwc3_0: usb@38100000 {
 				compatible = "snps,dwc3";
 				reg = <0x38100000 0x10000>;
 				clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
@@ -869,7 +869,7 @@
 			ranges;
 			status = "disabled";
 
-			usb_dwc3_1: dwc3@38200000 {
+			usb_dwc3_1: usb@38200000 {
 				compatible = "snps,dwc3";
 				reg = <0x38200000 0x10000>;
 				clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
-- 
1.8.3

Re: [PATCH 0/2] dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node "snps,dwc3"

[Shawn Guo]

On Mon, Mar 29, 2021 at 03:27:12PM +0800, Zhen Lei wrote:
> File snps,dwc3.yaml describes the schema of Synopsys DesignWare USB3
> Controller, it directly or indirectly contains "$ref: usb.yaml". So the
> node name of "snps,dwc3" must start with "usb". Otherwise, the following
> warning will be displayed:
> 
> Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.example.dt.yaml: \
> dwc3@38100000: $nodename:0: 'dwc3@38100000' does not match '^usb(@.*)?'
>         From schema: Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> 
> 
> Zhen Lei (2):
>   dt-bindings: usb: dwc3-imx8mp: Use the correct name for child node
>     "snps,dwc3"
>   arm64: dts: imx8mp: Use the correct name for child node "snps,dwc3"

Applied both, thanks.