* [PATCH] irqchip/sifive-plic: Mark two global variables __ro_after_init
@ 2021-03-29 18:09 Jisheng Zhang
2021-04-07 12:31 ` Marc Zyngier
2021-04-07 12:38 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jisheng Zhang
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2021-03-29 18:09 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley
Cc: linux-kernel, linux-riscv
From: Jisheng Zhang <jszhang@kernel.org>
All of these two are never modified after init, so they can be
__ro_after_init.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/irqchip/irq-sifive-plic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index 6f432d2a5ceb..97d4d04b0a80 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -77,8 +77,8 @@ struct plic_handler {
void __iomem *enable_base;
struct plic_priv *priv;
};
-static int plic_parent_irq;
-static bool plic_cpuhp_setup_done;
+static int plic_parent_irq __ro_after_init;
+static bool plic_cpuhp_setup_done __ro_after_init;
static DEFINE_PER_CPU(struct plic_handler, plic_handlers);
static inline void plic_toggle(struct plic_handler *handler,
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/sifive-plic: Mark two global variables __ro_after_init
2021-03-29 18:09 [PATCH] irqchip/sifive-plic: Mark two global variables __ro_after_init Jisheng Zhang
@ 2021-04-07 12:31 ` Marc Zyngier
2021-04-07 12:38 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jisheng Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2021-04-07 12:31 UTC (permalink / raw)
To: Paul Walmsley, Thomas Gleixner, Palmer Dabbelt, Jisheng Zhang
Cc: linux-kernel, linux-riscv
On Tue, 30 Mar 2021 02:09:11 +0800, Jisheng Zhang wrote:
> All of these two are never modified after init, so they can be
> __ro_after_init.
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/sifive-plic: Mark two global variables __ro_after_init
commit: e03b7c1bcbfad6f27b4682f638b98627c4e416ba
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/sifive-plic: Mark two global variables __ro_after_init
2021-03-29 18:09 [PATCH] irqchip/sifive-plic: Mark two global variables __ro_after_init Jisheng Zhang
2021-04-07 12:31 ` Marc Zyngier
@ 2021-04-07 12:38 ` irqchip-bot for Jisheng Zhang
1 sibling, 0 replies; 3+ messages in thread
From: irqchip-bot for Jisheng Zhang @ 2021-04-07 12:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Jisheng Zhang, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: e03b7c1bcbfad6f27b4682f638b98627c4e416ba
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/e03b7c1bcbfad6f27b4682f638b98627c4e416ba
Author: Jisheng Zhang <jszhang@kernel.org>
AuthorDate: Tue, 30 Mar 2021 02:09:11 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Wed, 07 Apr 2021 13:25:52 +01:00
irqchip/sifive-plic: Mark two global variables __ro_after_init
All of these two are never modified after init, so they can be
__ro_after_init.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210330020911.26423e9e@xhacker
---
drivers/irqchip/irq-sifive-plic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index 6f432d2..97d4d04 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -77,8 +77,8 @@ struct plic_handler {
void __iomem *enable_base;
struct plic_priv *priv;
};
-static int plic_parent_irq;
-static bool plic_cpuhp_setup_done;
+static int plic_parent_irq __ro_after_init;
+static bool plic_cpuhp_setup_done __ro_after_init;
static DEFINE_PER_CPU(struct plic_handler, plic_handlers);
static inline void plic_toggle(struct plic_handler *handler,
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-07 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 18:09 [PATCH] irqchip/sifive-plic: Mark two global variables __ro_after_init Jisheng Zhang
2021-04-07 12:31 ` Marc Zyngier
2021-04-07 12:38 ` [irqchip: irq/irqchip-next] " irqchip-bot for Jisheng Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).