* [PATCH -next] powerpc/eeh: Add correct inline functions
@ 2021-03-31 12:53 YueHaibing
2022-03-15 9:42 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2021-03-31 12:53 UTC (permalink / raw)
To: ruscur, oohall, mpe, benh, paulus, sbobroff
Cc: linuxppc-dev, linux-kernel, YueHaibing
pseries_eeh_add_device_early()/pseries_eeh_add_device_tree_early() is
never used since adding, however pseries_eeh_init_edev() and
pseries_eeh_init_edev_recursive() need their inline versions.
Fixes: b6eebb093cad ("powerpc/eeh: Make early EEH init pseries specific")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/include/asm/eeh.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index b1a5bba2e0b9..0b6c2a6711d3 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -357,8 +357,8 @@ static inline int eeh_phb_pe_create(struct pci_controller *phb) { return 0; }
void pseries_eeh_init_edev(struct pci_dn *pdn);
void pseries_eeh_init_edev_recursive(struct pci_dn *pdn);
#else
-static inline void pseries_eeh_add_device_early(struct pci_dn *pdn) { }
-static inline void pseries_eeh_add_device_tree_early(struct pci_dn *pdn) { }
+static inline void pseries_eeh_init_edev(struct pci_dn *pdn) { }
+static inline void pseries_eeh_init_edev_recursive(struct pci_dn *pdn) { }
#endif
#ifdef CONFIG_PPC64
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] powerpc/eeh: Add correct inline functions
2021-03-31 12:53 [PATCH -next] powerpc/eeh: Add correct inline functions YueHaibing
@ 2022-03-15 9:42 ` Christophe Leroy
2022-03-15 10:51 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2022-03-15 9:42 UTC (permalink / raw)
To: YueHaibing, ruscur, oohall, mpe, benh, paulus, sbobroff
Cc: linuxppc-dev, linux-kernel
Le 31/03/2021 à 14:53, YueHaibing a écrit :
> pseries_eeh_add_device_early()/pseries_eeh_add_device_tree_early() is
> never used since adding, however pseries_eeh_init_edev() and
> pseries_eeh_init_edev_recursive() need their inline versions.
>
> Fixes: b6eebb093cad ("powerpc/eeh: Make early EEH init pseries specific")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Those inline are not needed at all:
- pseries_eeh_init_edev_recursive() is only called from files build wich
CONFIG_HOTPLUG_PCI_RPA which depends on CONFIG_PSERIES and CONFIG_EEH
- pseries_eeh_init_edev() is used exclusively in
arch/powerpc/platforms/pseries/eeh_pseries.c and should be made static.
Can you update your patch ?
Thanks
Christophe
> ---
> arch/powerpc/include/asm/eeh.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
> index b1a5bba2e0b9..0b6c2a6711d3 100644
> --- a/arch/powerpc/include/asm/eeh.h
> +++ b/arch/powerpc/include/asm/eeh.h
> @@ -357,8 +357,8 @@ static inline int eeh_phb_pe_create(struct pci_controller *phb) { return 0; }
> void pseries_eeh_init_edev(struct pci_dn *pdn);
> void pseries_eeh_init_edev_recursive(struct pci_dn *pdn);
> #else
> -static inline void pseries_eeh_add_device_early(struct pci_dn *pdn) { }
> -static inline void pseries_eeh_add_device_tree_early(struct pci_dn *pdn) { }
> +static inline void pseries_eeh_init_edev(struct pci_dn *pdn) { }
> +static inline void pseries_eeh_init_edev_recursive(struct pci_dn *pdn) { }
> #endif
>
> #ifdef CONFIG_PPC64
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] powerpc/eeh: Add correct inline functions
2022-03-15 9:42 ` Christophe Leroy
@ 2022-03-15 10:51 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2022-03-15 10:51 UTC (permalink / raw)
To: Christophe Leroy, ruscur, oohall, mpe, benh, paulus, sbobroff
Cc: linuxppc-dev, linux-kernel
On 2022/3/15 17:42, Christophe Leroy wrote:
>
>
> Le 31/03/2021 à 14:53, YueHaibing a écrit :
>> pseries_eeh_add_device_early()/pseries_eeh_add_device_tree_early() is
>> never used since adding, however pseries_eeh_init_edev() and
>> pseries_eeh_init_edev_recursive() need their inline versions.
>>
>> Fixes: b6eebb093cad ("powerpc/eeh: Make early EEH init pseries specific")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Those inline are not needed at all:
> - pseries_eeh_init_edev_recursive() is only called from files build wich CONFIG_HOTPLUG_PCI_RPA which depends on CONFIG_PSERIES and CONFIG_EEH
> - pseries_eeh_init_edev() is used exclusively in
> arch/powerpc/platforms/pseries/eeh_pseries.c and should be made static.
>
> Can you update your patch ?
OK, will do it in v2.
>
> Thanks
> Christophe
>
>> ---
>> arch/powerpc/include/asm/eeh.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
>> index b1a5bba2e0b9..0b6c2a6711d3 100644
>> --- a/arch/powerpc/include/asm/eeh.h
>> +++ b/arch/powerpc/include/asm/eeh.h
>> @@ -357,8 +357,8 @@ static inline int eeh_phb_pe_create(struct pci_controller *phb) { return 0; }
>> void pseries_eeh_init_edev(struct pci_dn *pdn);
>> void pseries_eeh_init_edev_recursive(struct pci_dn *pdn);
>> #else
>> -static inline void pseries_eeh_add_device_early(struct pci_dn *pdn) { }
>> -static inline void pseries_eeh_add_device_tree_early(struct pci_dn *pdn) { }
>> +static inline void pseries_eeh_init_edev(struct pci_dn *pdn) { }
>> +static inline void pseries_eeh_init_edev_recursive(struct pci_dn *pdn) { }
>> #endif
>> #ifdef CONFIG_PPC64
> .
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 12:53 [PATCH -next] powerpc/eeh: Add correct inline functions YueHaibing
2022-03-15 9:42 ` Christophe Leroy
2022-03-15 10:51 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).