* [PATCH v1 1/1] driver core: platform: Declare early_platform_cleanup() prototype
@ 2021-03-31 15:05 Andy Shevchenko
2021-03-31 15:22 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-03-31 15:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel; +Cc: Andy Shevchenko, Guenter Roeck
Compiler is not happy:
CC drivers/base/platform.o
drivers/base/platform.c:1557:20: warning: no previous prototype for ‘early_platform_cleanup’ [-Wmissing-prototypes]
1557 | void __weak __init early_platform_cleanup(void) { }
| ^~~~~~~~~~~~~~~~~~~~~~
Declare early_platform_cleanup() prototype in the header to make everyone happy.
Fixes: eecd37e105f0 ("drivers: Fix boot problem on SuperH")
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/platform_device.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 3f23f6e430bf..cd81e060863c 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -359,4 +359,7 @@ static inline int is_sh_early_platform_device(struct platform_device *pdev)
}
#endif /* CONFIG_SUPERH */
+/* For now only SuperH uses it */
+void early_platform_cleanup(void);
+
#endif /* _PLATFORM_DEVICE_H_ */
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] driver core: platform: Declare early_platform_cleanup() prototype
2021-03-31 15:05 [PATCH v1 1/1] driver core: platform: Declare early_platform_cleanup() prototype Andy Shevchenko
@ 2021-03-31 15:22 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-03-31 15:22 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Greg Kroah-Hartman, linux-kernel
On Wed, Mar 31, 2021 at 06:05:25PM +0300, Andy Shevchenko wrote:
> Compiler is not happy:
>
> CC drivers/base/platform.o
> drivers/base/platform.c:1557:20: warning: no previous prototype for ‘early_platform_cleanup’ [-Wmissing-prototypes]
> 1557 | void __weak __init early_platform_cleanup(void) { }
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Declare early_platform_cleanup() prototype in the header to make everyone happy.
>
> Fixes: eecd37e105f0 ("drivers: Fix boot problem on SuperH")
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> include/linux/platform_device.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 3f23f6e430bf..cd81e060863c 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -359,4 +359,7 @@ static inline int is_sh_early_platform_device(struct platform_device *pdev)
> }
> #endif /* CONFIG_SUPERH */
>
> +/* For now only SuperH uses it */
> +void early_platform_cleanup(void);
> +
> #endif /* _PLATFORM_DEVICE_H_ */
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 15:05 [PATCH v1 1/1] driver core: platform: Declare early_platform_cleanup() prototype Andy Shevchenko
2021-03-31 15:22 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).