* [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create()
@ 2021-04-01 10:30 Yang Yingliang
2021-04-01 14:02 ` Benoit Parrot
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-04-01 10:30 UTC (permalink / raw)
To: linux-kernel, linux-media; +Cc: mchehab, bparrot
There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/ti-vpe/sc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti-vpe/sc.c
index 98f95082a6fd..0202d278523f 100644
--- a/drivers/media/platform/ti-vpe/sc.c
+++ b/drivers/media/platform/ti-vpe/sc.c
@@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, const char *res_name)
}
sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
- if (IS_ERR(sc->base)) {
- dev_err(&pdev->dev, "failed to ioremap\n");
+ if (IS_ERR(sc->base))
return ERR_CAST(sc->base);
- }
return sc;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create()
2021-04-01 10:30 [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create() Yang Yingliang
@ 2021-04-01 14:02 ` Benoit Parrot
0 siblings, 0 replies; 2+ messages in thread
From: Benoit Parrot @ 2021-04-01 14:02 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, linux-media, mchehab
Yang,
Thank you for the patch.
Yang Yingliang <yangyingliang@huawei.com> wrote on Thu [2021-Apr-01 18:30:15 +0800]:
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/ti-vpe/sc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti-vpe/sc.c
> index 98f95082a6fd..0202d278523f 100644
> --- a/drivers/media/platform/ti-vpe/sc.c
> +++ b/drivers/media/platform/ti-vpe/sc.c
> @@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, const char *res_name)
> }
>
> sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
> - if (IS_ERR(sc->base)) {
> - dev_err(&pdev->dev, "failed to ioremap\n");
> + if (IS_ERR(sc->base))
> return ERR_CAST(sc->base);
> - }
Reviewed-by: Benoit Parrot <bparrot@ti.com>
>
> return sc;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-02 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 10:30 [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create() Yang Yingliang
2021-04-01 14:02 ` Benoit Parrot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).