* [PATCH -next] powerpc/security: Make symbol 'stf_barrier' static
@ 2021-04-08 3:39 Li Huafei
2021-04-19 3:59 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Li Huafei @ 2021-04-08 3:39 UTC (permalink / raw)
To: mpe, benh, paulus, npiggin, jniethe5, alistair
Cc: linuxppc-dev, linux-kernel, yangjihong1, zhangjinhao2, lihuafei1
The sparse tool complains as follows:
arch/powerpc/kernel/security.c:253:6: warning:
symbol 'stf_barrier' was not declared. Should it be static?
This symbol is not used outside of security.c, so this commit marks it
static.
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
---
arch/powerpc/kernel/security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/security.c b/arch/powerpc/kernel/security.c
index e4e1a94ccf6a..4de6bbd9672e 100644
--- a/arch/powerpc/kernel/security.c
+++ b/arch/powerpc/kernel/security.c
@@ -250,7 +250,7 @@ ssize_t cpu_show_spectre_v2(struct device *dev, struct device_attribute *attr, c
static enum stf_barrier_type stf_enabled_flush_types;
static bool no_stf_barrier;
-bool stf_barrier;
+static bool stf_barrier;
static int __init handle_no_stf_barrier(char *p)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] powerpc/security: Make symbol 'stf_barrier' static
2021-04-08 3:39 [PATCH -next] powerpc/security: Make symbol 'stf_barrier' static Li Huafei
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: npiggin, benh, alistair, mpe, paulus, Li Huafei, jniethe5
Cc: linux-kernel, yangjihong1, linuxppc-dev, zhangjinhao2
On Thu, 8 Apr 2021 11:39:51 +0800, Li Huafei wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/kernel/security.c:253:6: warning:
> symbol 'stf_barrier' was not declared. Should it be static?
>
> This symbol is not used outside of security.c, so this commit marks it
> static.
Applied to powerpc/next.
[1/1] powerpc/security: Make symbol 'stf_barrier' static
https://git.kernel.org/powerpc/c/7f262b4dcf7edf75097c3946e676d6c6d77fc599
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-19 4:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 3:39 [PATCH -next] powerpc/security: Make symbol 'stf_barrier' static Li Huafei
2021-04-19 3:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).