* [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable
@ 2021-04-08 11:19 Fabio M. De Francesco
2021-04-09 14:12 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Fabio M. De Francesco @ 2021-04-08 11:19 UTC (permalink / raw)
To: Greg KH, outreachy-kernel, linux-staging, linux-kernel
Cc: Fabio M. De Francesco
Change the type of fw_current_in_ps_mode from u8 to bool, because
it is used everywhere as a bool and, accordingly, it should be
declared as a bool. Shorten the controlling
expression of an 'if' statement.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 96fe172ced8d..8dc4dd8c6d4c 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -348,7 +348,7 @@ void rtw_hal_dm_watchdog(struct adapter *padapter)
void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
{
- if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode == true) {
+ if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) {
if (padapter->HalFunc.hal_dm_watchdog_in_lps)
padapter->HalFunc.hal_dm_watchdog_in_lps(padapter); /* this function caller is in interrupt context */
}
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index 5450d20b44a6..c03ae33b0aa6 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -203,7 +203,7 @@ struct pwrctrl_priv {
u8 LpsIdleCount;
u8 power_mgnt;
u8 org_power_mgnt;
- u8 fw_current_in_ps_mode;
+ bool fw_current_in_ps_mode;
unsigned long DelayLPSLastTimeStamp;
s32 pnp_current_pwr_state;
u8 pnp_bstop_trx;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable
2021-04-08 11:19 [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable Fabio M. De Francesco
@ 2021-04-09 14:12 ` Greg KH
2021-04-09 17:14 ` Fabio M. De Francesco
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2021-04-09 14:12 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: outreachy-kernel, linux-staging, linux-kernel
On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote:
> Change the type of fw_current_in_ps_mode from u8 to bool, because
> it is used everywhere as a bool and, accordingly, it should be
> declared as a bool. Shorten the controlling
> expression of an 'if' statement.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
I now have 3 patches, I think, for this same driver, from you, and I
have no idea what order they should be applied in.
So I'm going to drop them all. Can you please resend me a patch series,
with all of the outstanding patches sent to me from you that I have not
applied yet, so that I know which ones to look at and what order to
apply them in?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable
2021-04-09 14:12 ` Greg KH
@ 2021-04-09 17:14 ` Fabio M. De Francesco
2021-04-09 17:24 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Fabio M. De Francesco @ 2021-04-09 17:14 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel, linux-staging, linux-kernel
On Friday, April 9, 2021 4:12:37 PM CEST Greg KH wrote:
> On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote:
> > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > it is used everywhere as a bool and, accordingly, it should be
> > declared as a bool. Shorten the controlling
> > expression of an 'if' statement.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
>
> I now have 3 patches, I think, for this same driver, from you, and I
> have no idea what order they should be applied in.
>
> So I'm going to drop them all. Can you please resend me a patch series,
> with all of the outstanding patches sent to me from you that I have not
> applied yet, so that I know which ones to look at and what order to
> apply them in?
>
I just sent in the series of patches you requested. Hope the work is as you
expected.
Thanks,
Fabio
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable
2021-04-09 17:14 ` Fabio M. De Francesco
@ 2021-04-09 17:24 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2021-04-09 17:24 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: Greg KH, outreachy-kernel, linux-staging, linux-kernel
On Fri, 9 Apr 2021, Fabio M. De Francesco wrote:
> On Friday, April 9, 2021 4:12:37 PM CEST Greg KH wrote:
> > On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote:
> > > Change the type of fw_current_in_ps_mode from u8 to bool, because
> > > it is used everywhere as a bool and, accordingly, it should be
> > > declared as a bool. Shorten the controlling
> > > expression of an 'if' statement.
> > >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > >
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > I now have 3 patches, I think, for this same driver, from you, and I
> > have no idea what order they should be applied in.
> >
> > So I'm going to drop them all. Can you please resend me a patch series,
> > with all of the outstanding patches sent to me from you that I have not
> > applied yet, so that I know which ones to look at and what order to
> > apply them in?
> >
> I just sent in the series of patches you requested. Hope the work is as you
> expected.
If you make multiple patches that touch the same files they have to be in
a series.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-09 17:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 11:19 [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable Fabio M. De Francesco
2021-04-09 14:12 ` Greg KH
2021-04-09 17:14 ` Fabio M. De Francesco
2021-04-09 17:24 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).