* [PATCH -next] mailbox: arm_mhu_db: Remove redundant dev_err call in mhu_db_probe()
@ 2021-04-09 11:07 Qiheng Lin
0 siblings, 0 replies; only message in thread
From: Qiheng Lin @ 2021-04-09 11:07 UTC (permalink / raw)
To: linqiheng, Jassi Brar; +Cc: linux-kernel, kernel-janitors, Hulk Robot
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/mailbox/arm_mhu_db.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mailbox/arm_mhu_db.c b/drivers/mailbox/arm_mhu_db.c
index 8eb66c4ecf5b..9e9c1261da2a 100644
--- a/drivers/mailbox/arm_mhu_db.c
+++ b/drivers/mailbox/arm_mhu_db.c
@@ -278,10 +278,8 @@ static int mhu_db_probe(struct amba_device *adev, const struct amba_id *id)
return -ENOMEM;
mhu->base = devm_ioremap_resource(dev, &adev->res);
- if (IS_ERR(mhu->base)) {
- dev_err(dev, "ioremap failed\n");
+ if (IS_ERR(mhu->base))
return PTR_ERR(mhu->base);
- }
chans = devm_kcalloc(dev, max_chans, sizeof(*chans), GFP_KERNEL);
if (!chans)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-09 11:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 11:07 [PATCH -next] mailbox: arm_mhu_db: Remove redundant dev_err call in mhu_db_probe() Qiheng Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).