* [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config()
@ 2021-04-08 11:31 Wang Wensheng
2021-04-12 18:28 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Wang Wensheng @ 2021-04-08 11:31 UTC (permalink / raw)
To: mike.marciniszyn, dennis.dalessandro, dledford, jgg,
brendan.cunningham, ira.weiny, sudeep.dutt, linux-rdma,
linux-kernel
Cc: rui.xiang
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 7724105686e7 ("IB/hfi1: add driver files")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
---
drivers/infiniband/hw/hfi1/firmware.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
index 0e83d4b..2cf102b 100644
--- a/drivers/infiniband/hw/hfi1/firmware.c
+++ b/drivers/infiniband/hw/hfi1/firmware.c
@@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd)
dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n",
__func__, (ptr -
(u32 *)dd->platform_config.data));
+ ret = -EINVAL;
goto bail;
}
/* Jump the CRC DWORD */
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config()
2021-04-08 11:31 [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config() Wang Wensheng
@ 2021-04-12 18:28 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-04-12 18:28 UTC (permalink / raw)
To: Wang Wensheng
Cc: mike.marciniszyn, dennis.dalessandro, dledford,
brendan.cunningham, ira.weiny, sudeep.dutt, linux-rdma,
linux-kernel, rui.xiang
On Thu, Apr 08, 2021 at 11:31:40AM +0000, Wang Wensheng wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
> ---
> drivers/infiniband/hw/hfi1/firmware.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-12 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 11:31 [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config() Wang Wensheng
2021-04-12 18:28 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).