* [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler
@ 2021-04-16 3:40 zhuguangqing83
2021-04-16 8:46 ` Krzysztof Kozlowski
2021-04-16 12:12 ` Alex Elder
0 siblings, 2 replies; 3+ messages in thread
From: zhuguangqing83 @ 2021-04-16 3:40 UTC (permalink / raw)
To: Alex Elder, David S . Miller, Jakub Kicinski
Cc: netdev, linux-kernel, Guangqing Zhu
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Coccinelle noticed:
drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
drivers/net/ipa/ipa_smp2p.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
index a5f7a79a1923..74e04427a711 100644
--- a/drivers/net/ipa/ipa_smp2p.c
+++ b/drivers/net/ipa/ipa_smp2p.c
@@ -183,7 +183,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
}
irq = ret;
- ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p);
+ ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT,
+ name, smp2p);
if (ret) {
dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name);
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler
2021-04-16 3:40 [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
@ 2021-04-16 8:46 ` Krzysztof Kozlowski
2021-04-16 12:12 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-16 8:46 UTC (permalink / raw)
To: zhuguangqing83
Cc: Alex Elder, David S . Miller, Jakub Kicinski, netdev, linux-kernel
On Fri, 16 Apr 2021 at 06:26, <zhuguangqing83@gmail.com> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Coccinelle noticed:
> drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> ---
> drivers/net/ipa/ipa_smp2p.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Did you test it? There are several patches like this all over the tree
so it looks like "let's fix everything from Coccinelle" because you
ignored at least in some of the cases that the handler is not the
default primary one. I am not saying that the change is bad, but
rather it looks automated and needs more consideration.
Best regards,
Krzysztof
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler
2021-04-16 3:40 [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-16 8:46 ` Krzysztof Kozlowski
@ 2021-04-16 12:12 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2021-04-16 12:12 UTC (permalink / raw)
To: zhuguangqing83, Alex Elder, David S . Miller, Jakub Kicinski
Cc: netdev, linux-kernel
On 4/15/21 10:40 PM, zhuguangqing83@gmail.com wrote:
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
This is not required here. -Alex
https://lore.kernel.org/netdev/d57e0a43-4d87-93cf-471c-c8185ea85ced@ieee.org/
> Coccinelle noticed:
> drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> ---
> drivers/net/ipa/ipa_smp2p.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index a5f7a79a1923..74e04427a711 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -183,7 +183,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
> }
> irq = ret;
>
> - ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p);
> + ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT,
> + name, smp2p);
> if (ret) {
> dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name);
> return ret;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-16 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 3:40 [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-16 8:46 ` Krzysztof Kozlowski
2021-04-16 12:12 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).