* [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error
@ 2021-04-12 5:32 Dinghao Liu
2021-04-12 9:23 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Dinghao Liu @ 2021-04-12 5:32 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald-Stadler,
Andy Shevchenko, Alexandru Ardelean, Matt Ranostay, linux-iio,
linux-kernel
When lidar_write_control() fails, a pairing PM usage counter
decrement is needed to keep the counter balanced.
Fixes: 4ac4e086fd8c5 ("iio: pulsedlight-lidar-lite: add runtime PM")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
Changelog:
v2: - Add the fix tag.
---
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
index c685f10b5ae4..cc206bfa09c7 100644
--- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
+++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
@@ -160,6 +160,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg)
ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE);
if (ret < 0) {
dev_err(&client->dev, "cannot send start measurement command");
+ pm_runtime_put_noidle(&client->dev);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error
2021-04-12 5:32 [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error Dinghao Liu
@ 2021-04-12 9:23 ` Andy Shevchenko
2021-04-18 9:45 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-04-12 9:23 UTC (permalink / raw)
To: Dinghao Liu
Cc: Kangjie Lu, Jonathan Cameron, Lars-Peter Clausen,
Peter Meerwald-Stadler, Alexandru Ardelean, Matt Ranostay,
linux-iio, Linux Kernel Mailing List
On Mon, Apr 12, 2021 at 8:32 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> When lidar_write_control() fails, a pairing PM usage counter
> decrement is needed to keep the counter balanced.
You forgot to collect given tags.
> Fixes: 4ac4e086fd8c5 ("iio: pulsedlight-lidar-lite: add runtime PM")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>
> Changelog:
>
> v2: - Add the fix tag.
> ---
> drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> index c685f10b5ae4..cc206bfa09c7 100644
> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> @@ -160,6 +160,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg)
> ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE);
> if (ret < 0) {
> dev_err(&client->dev, "cannot send start measurement command");
> + pm_runtime_put_noidle(&client->dev);
> return ret;
> }
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error
2021-04-12 9:23 ` Andy Shevchenko
@ 2021-04-18 9:45 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-04-18 9:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dinghao Liu, Kangjie Lu, Lars-Peter Clausen,
Peter Meerwald-Stadler, Alexandru Ardelean, Matt Ranostay,
linux-iio, Linux Kernel Mailing List
On Mon, 12 Apr 2021 12:23:43 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, Apr 12, 2021 at 8:32 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> >
> > When lidar_write_control() fails, a pairing PM usage counter
> > decrement is needed to keep the counter balanced.
>
> You forgot to collect given tags.
>
> > Fixes: 4ac4e086fd8c5 ("iio: pulsedlight-lidar-lite: add runtime PM")
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
I gathered up the tags by hand and applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> > ---
> >
> > Changelog:
> >
> > v2: - Add the fix tag.
> > ---
> > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > index c685f10b5ae4..cc206bfa09c7 100644
> > --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > @@ -160,6 +160,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg)
> > ret = lidar_write_control(data, LIDAR_REG_CONTROL_ACQUIRE);
> > if (ret < 0) {
> > dev_err(&client->dev, "cannot send start measurement command");
> > + pm_runtime_put_noidle(&client->dev);
> > return ret;
> > }
> >
> > --
> > 2.17.1
> >
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-18 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 5:32 [PATCH] [v2] iio: proximity: pulsedlight: Fix rumtime PM imbalance on error Dinghao Liu
2021-04-12 9:23 ` Andy Shevchenko
2021-04-18 9:45 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).