linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP
@ 2021-04-19 19:42 Robert Hancock
  2021-04-20  6:19 ` Michal Simek
  2021-04-20  8:23 ` Marc Zyngier
  0 siblings, 2 replies; 3+ messages in thread
From: Robert Hancock @ 2021-04-19 19:42 UTC (permalink / raw)
  To: tglx, maz; +Cc: michal.simek, linux-kernel, anirudh, Robert Hancock

Previously the XILINX_INTC config option was hidden and only
auto-selected on the MicroBlaze platform. However, this IP can also be
used on the Zynq and ZynqMP platforms as a secondary cascaded
controller. Allow this option to be user-enabled on those platforms.

Signed-off-by: Robert Hancock <robert.hancock@calian.com>
---
 drivers/irqchip/Kconfig | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 15536e321df5..1020cc5a7800 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -279,8 +279,13 @@ config XTENSA_MX
 	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
 
 config XILINX_INTC
-	bool
+	bool "Xilinx Interrupt Controller IP"
+	depends on MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST
 	select IRQ_DOMAIN
+	help
+	  Support for the Xilinx Interrupt Controller IP core.
+	  This is used as a primary controller with MicroBlaze and can also
+	  be used as a secondary chained controller on other platforms.
 
 config IRQ_CROSSBAR
 	bool
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP
  2021-04-19 19:42 [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP Robert Hancock
@ 2021-04-20  6:19 ` Michal Simek
  2021-04-20  8:23 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2021-04-20  6:19 UTC (permalink / raw)
  To: Robert Hancock, tglx, maz; +Cc: michal.simek, linux-kernel, anirudh



On 4/19/21 9:42 PM, Robert Hancock wrote:
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on the Zynq and ZynqMP platforms as a secondary cascaded
> controller. Allow this option to be user-enabled on those platforms.
> 
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> ---
>  drivers/irqchip/Kconfig | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 15536e321df5..1020cc5a7800 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -279,8 +279,13 @@ config XTENSA_MX
>  	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
>  
>  config XILINX_INTC
> -	bool
> +	bool "Xilinx Interrupt Controller IP"
> +	depends on MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST
>  	select IRQ_DOMAIN
> +	help
> +	  Support for the Xilinx Interrupt Controller IP core.
> +	  This is used as a primary controller with MicroBlaze and can also
> +	  be used as a secondary chained controller on other platforms.
>  
>  config IRQ_CROSSBAR
>  	bool
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP
  2021-04-19 19:42 [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP Robert Hancock
  2021-04-20  6:19 ` Michal Simek
@ 2021-04-20  8:23 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2021-04-20  8:23 UTC (permalink / raw)
  To: Robert Hancock; +Cc: tglx, michal.simek, linux-kernel, anirudh

On Mon, 19 Apr 2021 20:42:45 +0100,
Robert Hancock <robert.hancock@calian.com> wrote:
> 
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on the Zynq and ZynqMP platforms as a secondary cascaded
> controller. Allow this option to be user-enabled on those platforms.
> 
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> ---
>  drivers/irqchip/Kconfig | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 15536e321df5..1020cc5a7800 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -279,8 +279,13 @@ config XTENSA_MX
>  	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
>  
>  config XILINX_INTC
> -	bool
> +	bool "Xilinx Interrupt Controller IP"
> +	depends on MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST

Please drop COMPILE_TEST. As reported by the kernel test bot, there
are architectures it can't be compiled on.

	M.

-- 
Without deviation from the norm, progress is not possible.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-20  8:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 19:42 [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP Robert Hancock
2021-04-20  6:19 ` Michal Simek
2021-04-20  8:23 ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).