linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eli Cohen <elic@nvidia.com>
To: Jason Wang <jasowang@redhat.com>
Cc: <mst@redhat.com>, <virtualization@lists.linux-foundation.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] virtio_pci_modern: hide vp_modern_get_queue_notify_off()
Date: Wed, 21 Apr 2021 10:45:47 +0300	[thread overview]
Message-ID: <20210421074547.GE97533@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <20210415073147.19331-5-jasowang@redhat.com>

On Thu, Apr 15, 2021 at 03:31:44AM -0400, Jason Wang wrote:
> All users (both virtio-pci library and vp_vdpa driver) has been
> switched to use vp_modern_map_vq_notify(). So there's no need to
> export the low level helper of vp_modern_get_queue_notify_off().
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Reviewed-by: Eli Cohen <elic@nvidia.com>

> ---
>  drivers/virtio/virtio_pci_modern_dev.c | 5 ++---
>  include/linux/virtio_pci_modern.h      | 2 --
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c
> index 28cb5847fafa..5a657e56b46d 100644
> --- a/drivers/virtio/virtio_pci_modern_dev.c
> +++ b/drivers/virtio/virtio_pci_modern_dev.c
> @@ -584,14 +584,13 @@ EXPORT_SYMBOL_GPL(vp_modern_get_num_queues);
>   *
>   * Returns the notification offset for a virtqueue
>   */
> -u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev,
> -				   u16 index)
> +static u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev,
> +					  u16 index)
>  {
>  	vp_iowrite16(index, &mdev->common->queue_select);
>  
>  	return vp_ioread16(&mdev->common->queue_notify_off);
>  }
> -EXPORT_SYMBOL_GPL(vp_modern_get_queue_notify_off);
>  
>  /*
>   * vp_modern_map_vq_notify - map notification area for a
> diff --git a/include/linux/virtio_pci_modern.h b/include/linux/virtio_pci_modern.h
> index 1b95d39b00fc..179a2fb4bf37 100644
> --- a/include/linux/virtio_pci_modern.h
> +++ b/include/linux/virtio_pci_modern.h
> @@ -99,8 +99,6 @@ void vp_modern_set_queue_size(struct virtio_pci_modern_device *mdev,
>  u16 vp_modern_get_queue_size(struct virtio_pci_modern_device *mdev,
>  			     u16 idx);
>  u16 vp_modern_get_num_queues(struct virtio_pci_modern_device *mdev);
> -u16 vp_modern_get_queue_notify_off(struct virtio_pci_modern_device *mdev,
> -				   u16 idx);
>  void __iomem *vp_modern_map_capability(struct virtio_pci_modern_device *mdev, int off,
>  				       size_t minlen,
>  				       u32 align,
> -- 
> 2.18.1
> 

  reply	other threads:[~2021-04-21  7:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  7:31 [PATCH 0/7] Doorbell mapping support for virito-pci vDPA Jason Wang
2021-04-15  7:31 ` [PATCH 1/7] virtio_pci_modern: introduce helper to map vq notify area Jason Wang
2021-04-21  7:44   ` Eli Cohen
2021-04-15  7:31 ` [PATCH 2/7] virtio-pci library: switch to use vp_modern_map_vq_notify() Jason Wang
2021-04-21  7:44   ` Eli Cohen
2021-04-15  7:31 ` [PATCH 3/7] vp_vdpa: " Jason Wang
2021-04-21  7:45   ` Eli Cohen
2021-04-15  7:31 ` [PATCH 4/7] virtio_pci_modern: hide vp_modern_get_queue_notify_off() Jason Wang
2021-04-21  7:45   ` Eli Cohen [this message]
2021-04-15  7:31 ` [PATCH 5/7] virito_pci libray: hide vp_modern_map_capability() Jason Wang
2021-04-21  7:46   ` Eli Cohen
2021-04-15  7:31 ` [PATCH 6/7] virtio-pci library: report resource address Jason Wang
2021-04-15  7:31 ` [PATCH 7/7] vp_vdpa: report doorbell address Jason Wang
2021-04-21  7:46   ` Eli Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210421074547.GE97533@mtl-vdi-166.wap.labs.mlnx \
    --to=elic@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).