From: Eli Cohen <elic@nvidia.com>
To: Jason Wang <jasowang@redhat.com>
Cc: <mst@redhat.com>, <virtualization@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] vp_vdpa: report doorbell address
Date: Wed, 21 Apr 2021 10:46:51 +0300 [thread overview]
Message-ID: <20210421074651.GG97533@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <20210415073147.19331-8-jasowang@redhat.com>
On Thu, Apr 15, 2021 at 03:31:47AM -0400, Jason Wang wrote:
> This patch reports the per vq doorbell location and size to vDPA
> bus. Userspace can then map the doorbell via mmap() via vhost-vDPA bus
> driver.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Eli Cohen <elic@nvidia.com>
> ---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index 98205e54d089..002b928d0ca1 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -26,6 +26,7 @@ struct vp_vring {
> void __iomem *notify;
> char msix_name[VP_VDPA_NAME_SIZE];
> struct vdpa_callback cb;
> + resource_size_t notify_pa;
> int irq;
> };
>
> @@ -336,6 +337,19 @@ static void vp_vdpa_set_config_cb(struct vdpa_device *vdpa,
> vp_vdpa->config_cb = *cb;
> }
>
> +static struct vdpa_notification_area
> +vp_vdpa_get_vq_notification(struct vdpa_device *vdpa, u16 qid)
> +{
> + struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa);
> + struct virtio_pci_modern_device *mdev = &vp_vdpa->mdev;
> + struct vdpa_notification_area notify;
> +
> + notify.addr = vp_vdpa->vring[qid].notify_pa;
> + notify.size = mdev->notify_offset_multiplier;
> +
> + return notify;
> +}
> +
> static const struct vdpa_config_ops vp_vdpa_ops = {
> .get_features = vp_vdpa_get_features,
> .set_features = vp_vdpa_set_features,
> @@ -343,6 +357,7 @@ static const struct vdpa_config_ops vp_vdpa_ops = {
> .set_status = vp_vdpa_set_status,
> .get_vq_num_max = vp_vdpa_get_vq_num_max,
> .get_vq_state = vp_vdpa_get_vq_state,
> + .get_vq_notification = vp_vdpa_get_vq_notification,
> .set_vq_state = vp_vdpa_set_vq_state,
> .set_vq_cb = vp_vdpa_set_vq_cb,
> .set_vq_ready = vp_vdpa_set_vq_ready,
> @@ -416,7 +431,8 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> for (i = 0; i < vp_vdpa->queues; i++) {
> vp_vdpa->vring[i].irq = VIRTIO_MSI_NO_VECTOR;
> vp_vdpa->vring[i].notify =
> - vp_modern_map_vq_notify(mdev, i, NULL);
> + vp_modern_map_vq_notify(mdev, i,
> + &vp_vdpa->vring[i].notify_pa);
> if (!vp_vdpa->vring[i].notify) {
> dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
> goto err;
> --
> 2.18.1
>
prev parent reply other threads:[~2021-04-21 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 7:31 [PATCH 0/7] Doorbell mapping support for virito-pci vDPA Jason Wang
2021-04-15 7:31 ` [PATCH 1/7] virtio_pci_modern: introduce helper to map vq notify area Jason Wang
2021-04-21 7:44 ` Eli Cohen
2021-04-15 7:31 ` [PATCH 2/7] virtio-pci library: switch to use vp_modern_map_vq_notify() Jason Wang
2021-04-21 7:44 ` Eli Cohen
2021-04-15 7:31 ` [PATCH 3/7] vp_vdpa: " Jason Wang
2021-04-21 7:45 ` Eli Cohen
2021-04-15 7:31 ` [PATCH 4/7] virtio_pci_modern: hide vp_modern_get_queue_notify_off() Jason Wang
2021-04-21 7:45 ` Eli Cohen
2021-04-15 7:31 ` [PATCH 5/7] virito_pci libray: hide vp_modern_map_capability() Jason Wang
2021-04-21 7:46 ` Eli Cohen
2021-04-15 7:31 ` [PATCH 6/7] virtio-pci library: report resource address Jason Wang
2021-04-15 7:31 ` [PATCH 7/7] vp_vdpa: report doorbell address Jason Wang
2021-04-21 7:46 ` Eli Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421074651.GG97533@mtl-vdi-166.wap.labs.mlnx \
--to=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).