From: zhuguangqing83@gmail.com
To: Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Guangqing Zhu <zhuguangqing83@gmail.com>
Subject: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor
Date: Wed, 21 Apr 2021 22:36:50 +0800 [thread overview]
Message-ID: <20210421143650.16045-1-zhuguangqing83@gmail.com> (raw)
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
Empty list or fully traversed list points to list head, which is not
NULL (and before the first element containing real data).
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
v2:
- Modify commit message and code as suggested by Sebastian.
---
drivers/power/supply/cpcap-battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 6d5bcdb9f45d..a3fc0084cda0 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
break;
}
- if (!d)
+ if (list_entry_is_head(d, &ddata->irq_list, node))
return IRQ_NONE;
latest = cpcap_battery_latest(ddata);
--
2.17.1
next reply other threads:[~2021-04-21 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 14:36 zhuguangqing83 [this message]
2021-04-21 16:04 ` [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor Tony Lindgren
2021-04-21 17:19 ` Carl Philipp Klemm
2021-04-21 21:09 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421143650.16045-1-zhuguangqing83@gmail.com \
--to=zhuguangqing83@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).