From: Carl Philipp Klemm <philipp@uvos.xyz>
To: Tony Lindgren <tony@atomide.com>
Cc: zhuguangqing83@gmail.com, Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor
Date: Wed, 21 Apr 2021 19:19:33 +0200 [thread overview]
Message-ID: <20210421191933.6fa083e0b2496aedaef4957a@uvos.xyz> (raw)
In-Reply-To: <YIBNDrHlwqn5hrl2@atomide.com>
Looks good to me, but dosent appear to solve the bootup bug.
(this time reply all)
Reviewed-by: Carl Philipp Klemm <philipp@uvos.xyz>
Tested-by: Carl Philipp Klemm <philipp@uvos.xyz>
--
Carl Philipp Klemm <philipp@uvos.xyz> <carl@uvos.xyz>
On Wed, 21 Apr 2021 19:04:30 +0300
Tony Lindgren <tony@atomide.com> wrote:
> Hi,
>
> * zhuguangqing83@gmail.com <zhuguangqing83@gmail.com> [210421 14:38]:
> > From: Guangqing Zhu <zhuguangqing83@gmail.com>
> >
> > Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
> > Empty list or fully traversed list points to list head, which is not
> > NULL (and before the first element containing real data).
> >
> > Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> > ---
> > v2:
> > - Modify commit message and code as suggested by Sebastian.
>
> Thanks looks OK to me. Looks like there's no flag we need to set there when
> the entry is found, so this should do for the check.
>
> Hmm I wonder if this just might fix the issue where booting with a USB
> charger connected can hang..
>
> Reviewed-by: Tony Lindgren <tony@atomide.com>
>
> > ---
> > drivers/power/supply/cpcap-battery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> > index 6d5bcdb9f45d..a3fc0084cda0 100644
> > --- a/drivers/power/supply/cpcap-battery.c
> > +++ b/drivers/power/supply/cpcap-battery.c
> > @@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
> > break;
> > }
> >
> > - if (!d)
> > + if (list_entry_is_head(d, &ddata->irq_list, node))
> > return IRQ_NONE;
> >
> > latest = cpcap_battery_latest(ddata);
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2021-04-21 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 14:36 [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor zhuguangqing83
2021-04-21 16:04 ` Tony Lindgren
2021-04-21 17:19 ` Carl Philipp Klemm [this message]
2021-04-21 21:09 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421191933.6fa083e0b2496aedaef4957a@uvos.xyz \
--to=philipp@uvos.xyz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
--cc=zhuguangqing83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).