[PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The newly added driver is missing a dependency as shown by this
randconfig build failure:

arm-linux-gnueabi-ld: drivers/regulator/bd71815-regulator.o: in function `buck12_set_hw_dvs_levels':
bd71815-regulator.c:(.text+0x4b6): undefined reference to `rohm_regulator_set_dvs_levels'

Fixes: 1aad39001e85 ("regulator: Support ROHM BD71815 regulators")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 9d84d9245490..9aeb32c320aa 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -207,6 +207,7 @@ config REGULATOR_BD70528
 config REGULATOR_BD71815
 	tristate "ROHM BD71815 Power Regulator"
 	depends on MFD_ROHM_BD71828
+	select REGULATOR_ROHM
 	help
 	  This driver supports voltage regulators on ROHM BD71815 PMIC.
 	  This will enable support for the software controllable buck
-- 
2.29.2

Re: [PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

On Wed, Apr 21, 2021 at 03:54:27PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver is missing a dependency as shown by this
> randconfig build failure:

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[Arnd Bergmann]

On Wed, Apr 21, 2021 at 4:53 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Apr 21, 2021 at 03:54:27PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The newly added driver is missing a dependency as shown by this
> > randconfig build failure:
>
> This doesn't apply against current code, please check and resend.

It seems that the patch causing the build failure (5a8a64d9a38b)
is in Lee's mfd tree instead, with the description "Immutable branch
between MFD, Clock, GPIO, Regulator and RTC due for the v5.13
merge window".

There is also a commit with a related description in the regulator
tree as commit aaa8c4e05e32 ("Merge series "Support ROHM
BD71815 PMIC" from Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>:")
but this one only contains two commits (fb8fee9efdc and e3baacf542)
from the series in Lee's tree.

It looks like something went wrong in the coordination between the
trees, but I'm not quite sure what.

      Arnd

Re: [PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

On Wed, Apr 21, 2021 at 05:16:36PM +0200, Arnd Bergmann wrote:

> It looks like something went wrong in the coordination between the
> trees, but I'm not quite sure what.

Dunno if it was this series but Lee did send a pull request for
something which wasn't based on a dependency series from me that it
should've been.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[Matti Vaittinen]

On Wed, 2021-04-21 at 15:53 +0100, Mark Brown wrote:
> On Wed, Apr 21, 2021 at 03:54:27PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > The newly added driver is missing a dependency as shown by this
> > randconfig build failure:
> 
> This doesn't apply against current code, please check and resend.

I guess that the series which this change is patching was merged to
MFD-next but not yet to regulator tree. So, if I'm not mistaken the fix
needs to be applied to MFD - or wait until the rest of the series gets
into regulator tree.

In any case - thank you Arnd. This fix is correct and needed (reviewed
by me).

Best Regards
	Matti Vaittinen

Re: [PATCH] regulator: bd71815: select CONFIG_ROHM_REGULATOR

[Mark Brown]

On Wed, 21 Apr 2021 15:54:27 +0200, Arnd Bergmann wrote:
> The newly added driver is missing a dependency as shown by this
> randconfig build failure:
> 
> arm-linux-gnueabi-ld: drivers/regulator/bd71815-regulator.o: in function `buck12_set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0x4b6): undefined reference to `rohm_regulator_set_dvs_levels'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: bd71815: select CONFIG_ROHM_REGULATOR
      commit: 5ba3747dbc9ade2d22a8f5bff3c928cb41d35030

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark