[linux-next:master 14157/14231] kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static?

[linux-next:master 14157/14231] kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   b74523885a715463203d4ccc3cf8c85952d3701a
commit: edede6a2ecfe8553e8232eb863a7a13ef40da3a2 [14157/14231] kernel/resource: allow region_intersects users to hold resource_lock
config: i386-randconfig-s002-20210421 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=edede6a2ecfe8553e8232eb863a7a13ef40da3a2
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout edede6a2ecfe8553e8232eb863a7a13ef40da3a2
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> kernel/resource.c:505:5: sparse: sparse: symbol '__region_intersects' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36153 bytes --]

[RFC PATCH linux-next] kernel/resource: __region_intersects() can be static

[kernel test robot]

Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 resource.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 8faae19f8236e..a4bc6f66136c6 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn)
 }
 EXPORT_SYMBOL_GPL(page_is_ram);
 
-int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
-			unsigned long desc)
+static int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
+			       unsigned long desc)
 {
 	struct resource res;
 	int type = 0; int other = 0;

Re: [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static

[Andy Shevchenko]

On Thu, Apr 22, 2021 at 4:30 AM kernel test robot <lkp@intel.com> wrote:

Can you generate a commit message as well?
Otherwise looks valid to me, thanks!

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  resource.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 8faae19f8236e..a4bc6f66136c6 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn)
>  }
>  EXPORT_SYMBOL_GPL(page_is_ram);
>
> -int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
> -                       unsigned long desc)
> +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
> +                              unsigned long desc)
>  {
>         struct resource res;
>         int type = 0; int other = 0;



-- 
With Best Regards,
Andy Shevchenko