[PATCH v2 0/3] dt-bindings: serial: pl011: Fix some dtbs_check warnings

[PATCH v2 0/3] dt-bindings: serial: pl011: Fix some dtbs_check warnings

[Zhen Lei]

v1 --> v2:
1) Change to reference the kernel-defined serial.yaml
2) Move the new added "label: true" into /schemas/serial/serial.yaml

Zhen Lei (3):
  dt-bindings: serial: Normalize the node name of the serial port
  dt-bindings: serial: pl011: Change to reference the kernel-defined
    serial.yaml
  dt-bindings: serial: Add label property in serial.yaml

 Documentation/devicetree/bindings/serial/pl011.yaml  | 4 ++--
 Documentation/devicetree/bindings/serial/serial.yaml | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.21.1

[PATCH v2 1/3] dt-bindings: serial: Normalize the node name of the serial port

[Zhen Lei]

Only letters, digits, and commas that describe the base address of the
serial port in hexadecimal format are allowed.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 65e75d040521..71aec7fda07d 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -21,7 +21,7 @@ description:
 
 properties:
   $nodename:
-    pattern: "^serial(@.*)?$"
+    pattern: "^serial(@[0-9a-f,]+)?$"
 
   cts-gpios:
     maxItems: 1
-- 
2.21.1

[PATCH v2 2/3] dt-bindings: serial: pl011: Change to reference the kernel-defined serial.yaml

[Zhen Lei]

The /schemas/serial.yaml from dt-schema only has the property $nodename,
whereas the kernel-defined /schemas/serial/serial.yaml contains more
useful properties, support for more complex application scenarios.

For example:
1) The property "current-speed" in fsl-lx2160a.dtsi
2) The subnode "bluetooth" in hi3660-hikey960.dts

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 Documentation/devicetree/bindings/serial/pl011.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
index 1f8e9f2644b6..142187337c76 100644
--- a/Documentation/devicetree/bindings/serial/pl011.yaml
+++ b/Documentation/devicetree/bindings/serial/pl011.yaml
@@ -10,7 +10,7 @@ maintainers:
   - Rob Herring <robh@kernel.org>
 
 allOf:
-  - $ref: /schemas/serial.yaml#
+  - $ref: serial.yaml#
 
 # Need a custom select here or 'arm,primecell' will match on lots of nodes
 select:
@@ -103,7 +103,7 @@ dependencies:
   poll-rate-ms: [ auto-poll ]
   poll-timeout-ms: [ auto-poll ]
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.21.1

[PATCH v2 3/3] dt-bindings: serial: Add label property in serial.yaml

[Zhen Lei]

When there is more than one serial port present, the property 'label'
allows a custom name to be used for briefly describe the usage or position
of each serial port.

Without this "label" property, many dtbs_check warnings similar to the
following are reported:
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dt.yaml: \
serial@ffd74000: Additional properties are not allowed ('label' was unexpected)
        From schema: Documentation/devicetree/bindings/serial/pl011.yaml

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 Documentation/devicetree/bindings/serial/serial.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 71aec7fda07d..04ec229cbb4f 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -23,6 +23,8 @@ properties:
   $nodename:
     pattern: "^serial(@[0-9a-f,]+)?$"
 
+  label: true
+
   cts-gpios:
     maxItems: 1
     description:
-- 
2.21.1

Re: [PATCH v2 1/3] dt-bindings: serial: Normalize the node name of the serial port

[Rob Herring]

On Thu, Apr 22, 2021 at 04:58:35PM +0800, Zhen Lei wrote:
> Only letters, digits, and commas that describe the base address of the
> serial port in hexadecimal format are allowed.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
> index 65e75d040521..71aec7fda07d 100644
> --- a/Documentation/devicetree/bindings/serial/serial.yaml
> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
> @@ -21,7 +21,7 @@ description:
>  
>  properties:
>    $nodename:
> -    pattern: "^serial(@.*)?$"
> +    pattern: "^serial(@[0-9a-f,]+)?$"

The format of unit-addresses is dictated by the bus (parent), so this is 
the wrong place to enforce this. 

Rob

Re: [PATCH v2 2/3] dt-bindings: serial: pl011: Change to reference the kernel-defined serial.yaml

[Rob Herring]

On Thu, Apr 22, 2021 at 04:58:36PM +0800, Zhen Lei wrote:
> The /schemas/serial.yaml from dt-schema only has the property $nodename,
> whereas the kernel-defined /schemas/serial/serial.yaml contains more
> useful properties, support for more complex application scenarios.
> 
> For example:
> 1) The property "current-speed" in fsl-lx2160a.dtsi
> 2) The subnode "bluetooth" in hi3660-hikey960.dts
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/serial/pl011.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

What about all these:

$ git grep 'schemas/serial.yaml'
Documentation/devicetree/bindings/serial/8250.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/ingenic,uart.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/pl011.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/qca,ar9330-uart.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/samsung_uart.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/sifive-serial.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml:  - $ref: /schemas/serial.yaml#
Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml:    $ref: /schemas/serial.yaml#

Re: [PATCH v2 3/3] dt-bindings: serial: Add label property in serial.yaml

[Rob Herring]

On Thu, 22 Apr 2021 16:58:37 +0800, Zhen Lei wrote:
> When there is more than one serial port present, the property 'label'
> allows a custom name to be used for briefly describe the usage or position
> of each serial port.
> 
> Without this "label" property, many dtbs_check warnings similar to the
> following are reported:
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dt.yaml: \
> serial@ffd74000: Additional properties are not allowed ('label' was unexpected)
>         From schema: Documentation/devicetree/bindings/serial/pl011.yaml
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  Documentation/devicetree/bindings/serial/serial.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 1/3] dt-bindings: serial: Normalize the node name of the serial port

[Leizhen (ThunderTown)]

On 2021/4/30 23:18, Rob Herring wrote:
> On Thu, Apr 22, 2021 at 04:58:35PM +0800, Zhen Lei wrote:
>> Only letters, digits, and commas that describe the base address of the
>> serial port in hexadecimal format are allowed.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
>> index 65e75d040521..71aec7fda07d 100644
>> --- a/Documentation/devicetree/bindings/serial/serial.yaml
>> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
>> @@ -21,7 +21,7 @@ description:
>>  
>>  properties:
>>    $nodename:
>> -    pattern: "^serial(@.*)?$"
>> +    pattern: "^serial(@[0-9a-f,]+)?$"
> 
> The format of unit-addresses is dictated by the bus (parent), so this is 
> the wrong place to enforce this. 

Okay, so I'll leave this place unchanged.

> 
> Rob
> 
> .
> 

Re: [PATCH v2 2/3] dt-bindings: serial: pl011: Change to reference the kernel-defined serial.yaml

[Leizhen (ThunderTown)]

On 2021/4/30 23:21, Rob Herring wrote:
> On Thu, Apr 22, 2021 at 04:58:36PM +0800, Zhen Lei wrote:
>> The /schemas/serial.yaml from dt-schema only has the property $nodename,
>> whereas the kernel-defined /schemas/serial/serial.yaml contains more
>> useful properties, support for more complex application scenarios.
>>
>> For example:
>> 1) The property "current-speed" in fsl-lx2160a.dtsi
>> 2) The subnode "bluetooth" in hi3660-hikey960.dts
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  Documentation/devicetree/bindings/serial/pl011.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> What about all these:

Currently, the extended attributes described in /schemas/serial/serial.yaml are
not referenced in the dts of other serial ports except pl011. So I didn't change
them. At least I run dtbs_check one by one on the ARM64 platform, no warning is
reported. Now, it seems that I was wrong, /schemas/serial/serial.yaml is applicable
to all serial ports. Even if those attributes are not currently referenced, the
reference relationship should be corrected in advance.

> 
> $ git grep 'schemas/serial.yaml'
> Documentation/devicetree/bindings/serial/8250.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/ingenic,uart.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/pl011.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/qca,ar9330-uart.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/samsung_uart.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/sifive-serial.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml:  - $ref: /schemas/serial.yaml#
> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml:    $ref: /schemas/serial.yaml#
> 
> .
>