* [PATCH v3] drm: rcar: unbreak the R-Car menu items
@ 2021-04-24 3:46 Randy Dunlap
2021-05-15 0:36 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-04-24 3:46 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Laurent Pinchart, Kieran Bingham, dri-devel,
linux-renesas-soc, Koji Matsuoka, David Airlie,
Geert Uytterhoeven
DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
symbols do not depend on DRM_RCAR_DU, the menu presentation is
broken for the following R-Car Kconfig symbols.
Use an if/endif block to make all of these symbols depend on
DRM_RCAR_DU (and remove the separate "depends on DRM_RCAR_DU").
This makes the kconfig menu presentation much cleaner.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2: use an if/endif block for the dependencies (thanks, Geert)
v3: still applicable -- update/rebase
Applies after today's earlier patch to fix undefined reference
build errors for R-Car (probably won't matter).
I did this patch one year ago and then forgot about it somehow.
Rediscovered & updated it today.
drivers/gpu/drm/rcar-du/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- linux-next-20210423.orig/drivers/gpu/drm/rcar-du/Kconfig
+++ linux-next-20210423/drivers/gpu/drm/rcar-du/Kconfig
@@ -14,10 +14,11 @@ config DRM_RCAR_DU
Choose this option if you have an R-Car chipset.
If M is selected the module will be called rcar-du-drm.
+if DRM_RCAR_DU
+
config DRM_RCAR_CMM
tristate "R-Car DU Color Management Module (CMM) Support"
depends on DRM && OF
- depends on DRM_RCAR_DU
help
Enable support for R-Car Color Management Module (CMM).
@@ -41,7 +42,6 @@ config DRM_RCAR_LVDS
config DRM_RCAR_VSP
bool "R-Car DU VSP Compositor Support" if ARM
default y if ARM64
- depends on DRM_RCAR_DU
depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && DRM_RCAR_DU=m)
help
Enable support to expose the R-Car VSP Compositor as KMS planes.
@@ -49,4 +49,5 @@ config DRM_RCAR_VSP
config DRM_RCAR_WRITEBACK
bool
default y if ARM64
- depends on DRM_RCAR_DU
+
+endif # DRM_RCAR_DU
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] drm: rcar: unbreak the R-Car menu items
2021-04-24 3:46 [PATCH v3] drm: rcar: unbreak the R-Car menu items Randy Dunlap
@ 2021-05-15 0:36 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-05-15 0:36 UTC (permalink / raw)
To: linux-kernel
Cc: Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc,
Koji Matsuoka, David Airlie, Geert Uytterhoeven
ping?
thanks.
On 4/23/21 8:46 PM, Randy Dunlap wrote:
> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
> symbols do not depend on DRM_RCAR_DU, the menu presentation is
> broken for the following R-Car Kconfig symbols.
>
> Use an if/endif block to make all of these symbols depend on
> DRM_RCAR_DU (and remove the separate "depends on DRM_RCAR_DU").
> This makes the kconfig menu presentation much cleaner.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v2: use an if/endif block for the dependencies (thanks, Geert)
> v3: still applicable -- update/rebase
>
> Applies after today's earlier patch to fix undefined reference
> build errors for R-Car (probably won't matter).
>
> I did this patch one year ago and then forgot about it somehow.
> Rediscovered & updated it today.
>
> drivers/gpu/drm/rcar-du/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- linux-next-20210423.orig/drivers/gpu/drm/rcar-du/Kconfig
> +++ linux-next-20210423/drivers/gpu/drm/rcar-du/Kconfig
> @@ -14,10 +14,11 @@ config DRM_RCAR_DU
> Choose this option if you have an R-Car chipset.
> If M is selected the module will be called rcar-du-drm.
>
> +if DRM_RCAR_DU
> +
> config DRM_RCAR_CMM
> tristate "R-Car DU Color Management Module (CMM) Support"
> depends on DRM && OF
> - depends on DRM_RCAR_DU
> help
> Enable support for R-Car Color Management Module (CMM).
>
> @@ -41,7 +42,6 @@ config DRM_RCAR_LVDS
> config DRM_RCAR_VSP
> bool "R-Car DU VSP Compositor Support" if ARM
> default y if ARM64
> - depends on DRM_RCAR_DU
> depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && DRM_RCAR_DU=m)
> help
> Enable support to expose the R-Car VSP Compositor as KMS planes.
> @@ -49,4 +49,5 @@ config DRM_RCAR_VSP
> config DRM_RCAR_WRITEBACK
> bool
> default y if ARM64
> - depends on DRM_RCAR_DU
> +
> +endif # DRM_RCAR_DU
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-15 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24 3:46 [PATCH v3] drm: rcar: unbreak the R-Car menu items Randy Dunlap
2021-05-15 0:36 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).